[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gcc-patches
Subject:    Re: [PATCH 5/5] Add plugin to recursively dump the source-ranges in a tree (v2)
From:       Dodji Seketeli <dodji () seketeli ! org>
Date:       2015-09-28 6:57:40
Message-ID: 86wpvbghej.fsf () seketeli ! org
[Download RAW message or body]

David Malcolm <dmalcolm@redhat.com> a écrit:

> This patch adds a test plugin that recurses down an expression tree,
> printing diagnostics showing the ranges of each node in the tree.
>
> It corresponds to:
>   [PATCH 15/22] Add plugin to recursively dump the source-ranges in a tree
>     https://gcc.gnu.org/ml/gcc-patches/2015-09/msg00741.html
> from v1 of the patch kit.
>
> Changes in v2:
>   * the output no longer contains the PARAM_DECL and INTEGER_CST
>     leaves since we no longer have range data for them; updated
>     the expected output accordingly.
>   * slightly updated to eliminate use of SOURCE_RANGE
>
> Updated screenshot:
>   https://dmalcolm.fedorapeople.org/gcc/2015-09-22/diagnostic-test-show-trees-1.html
>
> gcc/testsuite/ChangeLog:
> 	* gcc.dg/plugin/diagnostic-test-show-trees-1.c: New file.
> 	* gcc.dg/plugin/diagnostic_plugin_show_trees.c: New file.
> 	* gcc.dg/plugin/plugin.exp (plugin_test_list): Add
> 	diagnostic_plugin_show_trees.c and
> 	diagnostic-test-show-trees-1.c.

For what it's worth, this looks good to me.

Thanks!

-- 
		Dodji
[prev in list] [next in list] [prev in thread] [next in thread]