[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freetype-devel
Subject:    Re: [ft-devel] Another font variation bug fix
From:       Matthias Clasen <matthias.clasen () gmail ! com>
Date:       2017-12-18 21:37:42
Message-ID: CAFwd_vBupkouPd28LAR3-KmjrzO6Gqg2mcti6-wGKKLc4V-vXQ () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


the important change is the last hunk.

We store coords[i] in the local variable coord, then we apply the clamping
to coord, but then ...
we use coords[i] as input for the normalization, so the clamping is lost.
That is what my patch changes.

On Mon, Dec 18, 2017 at 2:48 PM, Werner LEMBERG <wl@gnu.org> wrote:

>
> Thanks for the patch, which I've applied with slight modifications.
>
> > Subject: [PATCH] Fix clamping of font variation axis values
> >
> > We were clamping the value correctly here, but then used the
> > original value for normalization anyway.
>
> This subject line and the omment I don't understand.  Your related
> code is just a minor beautification that doesn't change any
> functionality.  Am I missing something?
>
>
>     Werner
>

[Attachment #5 (text/html)]

<div dir="ltr"><div><div>the important change is the last hunk.<br><br></div>We store \
coords[i] in the local variable coord, then we apply the clamping to coord, but then \
...</div><div>we use coords[i] as input for the normalization, so the clamping is \
lost.<br></div>That is what my patch changes.<br></div><div \
class="gmail_extra"><br><div class="gmail_quote">On Mon, Dec 18, 2017 at 2:48 PM, \
Werner LEMBERG <span dir="ltr">&lt;<a href="mailto:wl@gnu.org" \
target="_blank">wl@gnu.org</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br> Thanks for \
the patch, which I&#39;ve applied with slight modifications.<br> <br>
&gt; Subject: [PATCH] Fix clamping of font variation axis values<br>
&gt;<br>
&gt; We were clamping the value correctly here, but then used the<br>
&gt; original value for normalization anyway.<br>
<br>
This subject line and the omment I don&#39;t understand.   Your related<br>
code is just a minor beautification that doesn&#39;t change any<br>
functionality.   Am I missing something?<br>
<span class="HOEnZb"><font color="#888888"><br>
<br>
      Werner<br>
</font></span></blockquote></div><br></div>



_______________________________________________
Freetype-devel mailing list
Freetype-devel@nongnu.org
https://lists.nongnu.org/mailman/listinfo/freetype-devel


[prev in list] [next in list] [prev in thread] [next in thread]