[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg-devel
Subject:    Re: [PATCH] xwayland: fix typo in non-modifier fallback path
From:       Olivier Fourdan <ofourdan () redhat ! com>
Date:       2018-05-29 7:06:27
Message-ID: CAP=2yySHDhadXoGjgATsTKHsp2XfkO4qpbYdPnU6cqfCOLid9w () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Tue, May 29, 2018 at 2:39 AM, Dave Airlie <airlied@gmail.com> wrote:

> From: Dave Airlie <airlied@redhat.com>
>
> Pointed out on irc by q66.
> ---
>  hw/xwayland/xwayland-glamor-gbm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/xwayland/xwayland-glamor-gbm.c
> b/hw/xwayland/xwayland-glamor-gbm.c
> index 29325adac..68c2cc32e 100644
> --- a/hw/xwayland/xwayland-glamor-gbm.c
> +++ b/hw/xwayland/xwayland-glamor-gbm.c
> @@ -272,7 +272,7 @@ xwl_glamor_gbm_get_wl_buffer_for_pixmap(PixmapPtr
> pixmap,
>  #else
>      num_planes = 1;
>      modifier = DRM_FORMAT_MOD_INVALID;
> -    strides[0] = gbm_go_get_stride(xwl_pixmap->bo);
> +    strides[0] = gbm_bo_get_stride(xwl_pixmap->bo);
>      offsets[0] = 0;
>  #endif
>
> --
> 2.17.0
>
>
Huhu, indeed!

First introduced with commit c8c276c95 then later moved to
xwayland-glamor-gbm.c
by commit 1545e2dbad

Reviewed-by: Olivier Fourdan <ofourdan@redhat.com>

[Attachment #5 (text/html)]

<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, May 29, 2018 \
at 2:39 AM, Dave Airlie <span dir="ltr">&lt;<a href="mailto:airlied@gmail.com" \
target="_blank">airlied@gmail.com</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex">From: Dave Airlie &lt;<a \
href="mailto:airlied@redhat.com">airlied@redhat.com</a>&gt;<br> <br>
Pointed out on irc by q66.<br>
---<br>
  hw/xwayland/xwayland-glamor-<wbr>gbm.c | 2 +-<br>
  1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/hw/xwayland/xwayland-glamor-<wbr>gbm.c \
b/hw/xwayland/xwayland-glamor-<wbr>gbm.c<br> index 29325adac..68c2cc32e 100644<br>
--- a/hw/xwayland/xwayland-glamor-<wbr>gbm.c<br>
+++ b/hw/xwayland/xwayland-glamor-<wbr>gbm.c<br>
@@ -272,7 +272,7 @@ xwl_glamor_gbm_get_wl_buffer_<wbr>for_pixmap(PixmapPtr \
pixmap,<br>  #else<br>
        num_planes = 1;<br>
        modifier = DRM_FORMAT_MOD_INVALID;<br>
-      strides[0] = gbm_go_get_stride(xwl_pixmap-&gt;<wbr>bo);<br>
+      strides[0] = gbm_bo_get_stride(xwl_pixmap-&gt;<wbr>bo);<br>
        offsets[0] = 0;<br>
  #endif<br>
<span class="gmail-HOEnZb"><font color="#888888">  <br>
-- <br>
2.17.0<br>
</font></span><br></blockquote></div></div><div class="gmail_extra"><br></div><div \
class="gmail_extra">Huhu, indeed!</div><div class="gmail_extra"><br></div><div \
class="gmail_extra"> First introduced with commit c8c276c95 then later moved to \
xwayland-glamor-<wbr>gbm.c by commit 1545e2dbad<br></div><div \
class="gmail_extra"><br></div><div class="gmail_extra">Reviewed-by: Olivier Fourdan \
&lt;<a href="mailto:ofourdan@redhat.com">ofourdan@redhat.com</a>&gt;</div><div \
class="gmail_extra"><br></div></div>


[Attachment #6 (text/plain)]

_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

[prev in list] [next in list] [prev in thread] [next in thread]