[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg-devel
Subject:    Re: [PATCH xserver 3/3] xwayland: Add glamor egl_backend for EGLStreams
From:       Mario Kleiner <mario.kleiner.de () gmail ! com>
Date:       2018-04-28 18:47:18
Message-ID: CAEsyxyjE9MS3eOu-A59dpjaVDT-hCJsxUj0im4txUH5YmpGCvg () mail ! gmail ! com
[Download RAW message or body]

Mini bug report:

My build of server 1.20-rc5 now fails on Ubuntu 16.04 due to lack of
epoxy_has_egl():

  CC       Xwayland-xwayland-glamor.o
xwayland-glamor.c: In function ‘xwl_glamor_egl_supports_device_probing':
xwayland-glamor.c:58:12: error: implicit declaration of function
‘epoxy_has_egl' [-Werror=implicit-function-declaration]
     return epoxy_has_egl() &&
            ^
xwayland-glamor.c:58:5: warning: nested extern declaration of
‘epoxy_has_egl' [-Wnested-externs]
     return epoxy_has_egl() &&
     ^
cc1: some warnings being treated as errors


Apparently libepoxy v1.4.0 or later is required to build now with that
function defined, so that needs some fix or version check.

Cheers,
-mario

On Tue, Apr 24, 2018 at 12:39 PM, Daniel Stone <daniel@fooishbar.org> wrote:
> Hi,
>
> On 20 April 2018 at 19:38, Adam Jackson <ajax@redhat.com> wrote:
>> This adds initial support for displaying Xwayland applications through
>> the use of EGLStreams and nvidia's custom wayland protocol by adding
>> another egl_backend driver. This also adds some additional egl_backend
>> hooks that are required to make things work properly.
>>
>> EGLStreams work a lot differently then the traditional way of handling
>> buffers with wayland. Unfortunately, there are also a LOT of various
>> pitfalls baked into it's design that need to be explained.
>
> This is every bit as unpleasant as the commit message details, but I'm
> not sure how you'd do it better, and it is at least minimally
> intrusive to the rest.
>
> Acked-by: Daniel Stone <daniels@collabora.com>
>
> Cheers,
> Daniel
> _______________________________________________
> xorg-devel@lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: https://lists.x.org/mailman/listinfo/xorg-devel
_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel
[prev in list] [next in list] [prev in thread] [next in thread]