[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg-devel
Subject:    Re: [PATCH xserver] automake: Fix 'make dist'
From:       Adam Jackson <ajax () nwnk ! net>
Date:       2018-03-28 19:13:19
Message-ID: f7a72a1b23df39b6ecf50a3df1d9faaa94b7dbfb.camel () nwnk ! net
[Download RAW message or body]

On Wed, 2018-03-28 at 14:08 +0200, Thierry Reding wrote:
> On Wed, Mar 28, 2018 at 12:17:48PM +0200, Olivier Fourdan wrote:
> > Automake would skip a few meson files that would prevent to build with
> > meson a dist file previously generated by automake.
> > 
> > Signed-off-by: Olivier Fourdan <ofourdan@redhat.com>
> > ---
> >  Makefile.am | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/Makefile.am b/Makefile.am
> > index 5ddfd5b84..32d4d21e7 100644
> > --- a/Makefile.am
> > +++ b/Makefile.am
> > @@ -140,6 +140,7 @@ distcheck-hook:
> >  EXTRA_DIST += \
> >  	meson_options.txt \
> >  	include/xorg-config.h.meson.in \
> > +	include/xwin-config.h.meson.in \
> 
> Just a thought: there's a Makefile.am in the include subdirectory, so
> maybe add this line there? Could be a follow-up patch, though, so:
> 
> Reviewed-by: Thierry Reding <treding@nvidia.com>

Yeah, might be a nice cleanup but it's no worse than what's already
there. Merged, thanks:

remote: I: patch #213386 updated using rev b355e55f500c18d55d0ac241e5f7e826ed62f555.
remote: I: 1 patch(es) updated to state Accepted.
To ssh://git.freedesktop.org/git/xorg/xserver
   16639ab77d..b355e55f50  master -> master

- ajax
_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel
[prev in list] [next in list] [prev in thread] [next in thread]