[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg-devel
Subject:    Re: [PATCH libICE 11/13] add check for mall
From:       Emil Velikov <emil.l.velikov () gmail ! com>
Date:       2017-10-31 15:18:06
Message-ID: CACvgo51CbsS7CYMR7MtLhmKLtbQxwmWU8fxpXRMfkq_2ickpug () mail ! gmail ! com
[Download RAW message or body]

On 31 October 2017 at 15:15, Emil Velikov <emil.l.velikov@gmail.com> wrote:
> On 18 October 2017 at 17:05, walter harms <wharms@bfs.de> wrote:
>>
>> fix a potential null pointer deference error and
>> properly dispose the affected message
>>
>>  Signed-off-by: Walter Harms <wharms@bfs.de>
>> ---
>>  src/process.c | 27 +++++++++++++++++++++++++++
>>  1 file changed, 27 insertions(+)
>>
> That patch seems ok, but I'm quite weary of it. There are a number of
> subtleties in ICE design I'd like to I'll leave it out ...for now at
> least.
>
... pressed Send a bit too early.

Some of these are due to the EXTRACT.*STRING macros mostly used in process.c.
Those macros have some 'interesting' protocol handling and memory allocation

-Emil
_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel
[prev in list] [next in list] [prev in thread] [next in thread]