[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg-devel
Subject:    Re: [PATCH xserver] present: disable page flip only when a slave crtc is active
From:       David Airlie <airlied () redhat ! com>
Date:       2017-01-31 19:05:37
Message-ID: 1150315334.18203088.1485889537734.JavaMail.zimbra () redhat ! com
[Download RAW message or body]



----- Original Message -----
> From: "Michel Dänzer" <michel@daenzer.net>
> To: "Qiang Yu" <Qiang.Yu@amd.com>
> Cc: xorg-devel@lists.x.org, "David Airlie" <airlied@redhat.com>
> Sent: Tuesday, 31 January, 2017 5:04:17 PM
> Subject: Re: [PATCH xserver] present: disable page flip only when a slave crtc is active
> 
> On 26/01/17 07:13 PM, Qiang Yu wrote:
> > 
> > @@ -145,7 +157,7 @@ present_check_flip(RRCrtcPtr    crtc,
> >          return FALSE;
> >  
> >      /* Fail to flip if we have slave outputs */
> > -    if (screen->output_slaves)
> > +    if (screen->output_slaves &&
> > present_check_output_slaves_active(screen))
> >          return FALSE;
> >  
> >      /* Make sure the window hasn't been redirected with Composite */
> > 
> 
> Actually, I'm not sure why we need to check for slave outputs here at
> all. Dave, did you run into an actual problem without the check, or was
> it just a theoretical concern? The commit log says:

You don't get an output on USB without the fix.

Dave.
_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel
[prev in list] [next in list] [prev in thread] [next in thread]