[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg-devel
Subject:    Re: [PATCH:xf86-video-mga] Fix pointer cast warning.
From:       Thomas Klausner <wiz () netbsd ! org>
Date:       2015-07-28 15:59:43
Message-ID: 20150728155943.GI20061 () danbala ! tuwien ! ac ! at
[Download RAW message or body]

So what can we do to make this progress?
 Thomas

On Thu, Feb 26, 2015 at 02:59:49AM -0500, Connor Behan wrote:
> On 25/02/15 06:41 PM, Tormod Volden wrote:
> >> And then disable the DownloadFromScreen() implementation, or perhaps
> >> even disable EXA altogether.
> > If nobody can find the real problem that is maybe all that can be done.
> The fix should be:
> 
> char *src = pExa->memoryBase + exaGetPixmapOffset(pSrc);
> 
> When I first saw exaGetPixmapFirstPixel() in savage and mga, I assumed
> this was just a shorthand for the above. But evidently it's not. As for
> other broken EXA drivers, I don't have hardware to test but some basic
> suggestions are:
> 
> 1. Use the above instead of pPix->devPrivate.ptr.
> 2. Make all hooks start by verifying that pSrc is non-NULL.
> 3. Remove UTS / DFS hooks unless they actually do a DRM blit.
> 


_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
[prev in list] [next in list] [prev in thread] [next in thread]