[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg-devel
Subject:    Re: [PATCH 03/19] input: Remove unused SetKeySymsMap
From:       Daniel Stone <daniel () fooishbar ! org>
Date:       2014-09-29 22:55:24
Message-ID: CAPj87rOjbNf_NPxaZJXDt2auToz5nmuDe2mfDCypcReX0RU6gQ () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hi,

On 29 September 2014 21:27, Keith Packard <keithp@keithp.com> wrote:

> Adam Jackson <ajax@redhat.com> writes:
> > Signed-off-by: Adam Jackson <ajax@redhat.com>
>
> What the heck was this ever used for?
>

It was a helper function from back when we kept a copy of the core keymap
_and_ the XKB keymap, and meticulously kept them both in sync. That was a
terrible idea, so we no longer do that.

Reviewed-by: Daniel Stone <daniels@collabora.com>

Cheers,
Daniel

[Attachment #5 (text/html)]

<div dir="ltr">Hi,<br><div class="gmail_extra"><br><div class="gmail_quote">On 29 \
September 2014 21:27, Keith Packard <span dir="ltr">&lt;<a \
href="mailto:keithp@keithp.com" target="_blank">keithp@keithp.com</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex">Adam Jackson &lt;<a \
href="mailto:ajax@redhat.com">ajax@redhat.com</a>&gt; writes:<br> &gt; Signed-off-by: \
Adam Jackson &lt;<a href="mailto:ajax@redhat.com">ajax@redhat.com</a>&gt;<br> <br>
What the heck was this ever used for?<br></blockquote><div><br></div><div>It was a \
helper function from back when we kept a copy of the core keymap _and_ the XKB \
keymap, and meticulously kept them both in sync. That was a terrible idea, so we no \
longer do that.</div><div><br></div><div>Reviewed-by: Daniel Stone &lt;<a \
href="mailto:daniels@collabora.com">daniels@collabora.com</a>&gt;</div><div><br></div><div>Cheers,</div><div>Daniel \
</div></div></div></div>



_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

[prev in list] [next in list] [prev in thread] [next in thread]