[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg-devel
Subject:    Re: [PATCH 19/19] x86emu: Undefine _NO_INLINE
From:       Keith Packard <keithp () keithp ! com>
Date:       2014-09-29 20:52:45
Message-ID: 86mw9ip2si.fsf () hiro ! keithp ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Mark Kettenis <mark.kettenis@xs4all.nl> writes:

>> From: Adam Jackson <ajax@redhat.com>
>> Date: Thu, 25 Sep 2014 13:37:35 -0400
>> 
>> Never defined by the server.
>
> Fairly certain it was never intended to be defined by the server, but
> used as a compile-time option to make debugging easier.

Yeah, when people were careful about using inline and not just leaving
them in the header file to be compiled static everywhere. However, at
this point, I'm pretty sure the server won't compile without inline, so
we shouldn't keep this pretense.

Reviewed-by: Keith Packard <keithp@keithp.com>

(won't merge until everyone is satisfied with the patch though).

-- 
keith.packard@intel.com

[Attachment #5 (application/pgp-signature)]

_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

[prev in list] [next in list] [prev in thread] [next in thread]