[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg-devel
Subject:    Re: [PATCH 01/19] damageext: dixLookupDrawable(M_WINDOW) -> dixLookupWindow
From:       Keith Packard <keithp () keithp ! com>
Date:       2014-09-29 20:25:43
Message-ID: 86eguuqim0.fsf () hiro ! keithp ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Adam Jackson <ajax@redhat.com> writes:

> Signed-off-by: Adam Jackson <ajax@redhat.com>
> ---
>  damageext/damageext.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/damageext/damageext.c b/damageext/damageext.c
> index 886f56d..4928379 100644
> --- a/damageext/damageext.c
> +++ b/damageext/damageext.c
> @@ -687,9 +687,8 @@ PanoramiXDamageCreate(ClientPtr client)
>                  rc = BadAlloc;
>              } else {
>                  damage->damage[i] = pDamage;
> -                rc = dixLookupDrawable(&pDrawable, draw->info[i].id, client,
> -                                       M_WINDOW,
> -                                       DixGetAttrAccess | DixReadAccess);
> +                rc = dixLookupWindow((WindowPtr *)&pDrawable, draw->info[i].id,
> +                                     client, DixGetAttrAccess | DixReadAccess);

This does change the error code from BadMatch to BadWindow, if the
object isn't found. Given that this is a Drawable on the wire, we should
leave this alone, even though an error here would indicate a bug in the
xinerama code.

-- 
keith.packard@intel.com

[Attachment #5 (application/pgp-signature)]

_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

[prev in list] [next in list] [prev in thread] [next in thread]