[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg-devel
Subject:    Re: [PATCH xinit] startx: Make the bugzilla reference in a comment survive cpp processing
From:       Alan Coopersmith <alan.coopersmith () oracle ! com>
Date:       2014-08-27 16:15:21
Message-ID: 53FE0419.9010600 () oracle ! com
[Download RAW message or body]

On 08/26/14 02:53 AM, Hans de Goede wrote:
> https://bugs.freedesktop.org/show_bug.cgi?id=83019
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>   startx.cpp | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/startx.cpp b/startx.cpp
> index 5dafce7..1c6fce0 100644
> --- a/startx.cpp
> +++ b/startx.cpp
> @@ -191,7 +191,7 @@ if [ x"$server" = x ]; then
>   #ifdef __linux__
>       XCOMM When starting the defaultserver start X on the current tty to avoid
>       XCOMM the startx session being seen as inactive:
> -    XCOMM https://bugzilla.redhat.com/show_bug.cgi?id=806491
> +    XCOMM "https://bugzilla.redhat.com/show_bug.cgi?id=806491"
>       tty=$(tty)
>       if expr match "$tty" '^/dev/tty[0-9]\+$' > /dev/null; then
>           tty_num=$(echo "$tty" | grep -oE '[0-9]+$')
>

I was thinking \ when I saw the bug, but quotes make it easier to read &
copy/paste out of the source, so that's a nice solution.

Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>

-- 
	-Alan Coopersmith-              alan.coopersmith@oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc
_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
[prev in list] [next in list] [prev in thread] [next in thread]