[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg-devel
Subject:    Re: [PATCH 04/18] Three minor warning and whitespace fixes
From:       Eric Anholt <eric () anholt ! net>
Date:       2014-08-26 17:58:56
Message-ID: 87iolfceu7.fsf () eliezer ! anholt ! net
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Keith Packard <keithp@keithp.com> writes:

> Eric Anholt <eric@anholt.net> writes:
>
>> So there's a bunch of disagreement between this new code and existing
>> practice about whitespace, and still misc unrelated whitespace changes
>> sprinkled into the remaining patches.  That makes me grumpy when
>> reviewing, but I don't actually care to block things due to that.  This
>> driver is enough of a disaster already that whitespace inconsistency
>> isn't its main problem.
>
> Yeah, I'm trying to use the server standard settings for all X work
> these days, so I'm using spaces instead of tabs. I can fix that if you
> want, but as you say, it's just annoyingly inconsistent.

Well, except that the indentation size is 8 instead of 4, and your
patches are inconsistent with themselves, even. :P

>> Patches 1-3, 5-6, 8, 12-15 are:
>>
>> Reviewed-by: Eric Anholt <eric@anholt.net>
>
> Thanks!
>
>> 16-18: I'm still looking at them.
>
> Cool.

I ended up putting up a keithp-glamor-rewrite branch in my tree -- I was
thinking I could pull out more non-glamor changes from the glamor patch,
and I got a couple of things that made the glamor patches more sensible,
but the rest looked harder.  There are some other little squashes in
that tree that I noticed along the way.  I think that's all I've got for
review on this series.

[Attachment #5 (application/pgp-signature)]

_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

[prev in list] [next in list] [prev in thread] [next in thread]