[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg-devel
Subject:    Re: [PATCH 2/6] xfree86: Report Present as a built-in module
From:       walter harms <wharms () bfs ! de>
Date:       2014-05-28 8:50:20
Message-ID: 5385A34C.6050807 () bfs ! de
[Download RAW message or body]



Am 28.05.2014 09:14, schrieb Chris Wilson:
> This is so that drivers can do a runtime check that Present is available,
> similar to existing runtime checks performed by the drivers for DRI.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  hw/xfree86/loader/loadmod.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/hw/xfree86/loader/loadmod.c b/hw/xfree86/loader/loadmod.c
> index f92ad8d..e1f649a 100644
> --- a/hw/xfree86/loader/loadmod.c
> +++ b/hw/xfree86/loader/loadmod.c
> @@ -841,6 +841,9 @@ static const char *compiled_in_modules[] = {
>  #if DRI3
>      "dri3",
>  #endif
> +#if PRESENT
> +    "present",
> +#endif
>      NULL
>  };
>  

just a remark,
PRESENT is not very descriptive (if DRI3 is better is a second point)
I would suggest a strategy like HAVE_PRESENT.
As non-english native it is easier to read.

and a second one:
I have seen sich #if forest grow in other projects, would it be an option
to have something like _PRESENT_TXT and more that somewhere else ?

#if PRESENT
#define _PRESENT_TXT "present",
#else
#define _PRESENT_TXT
#endif

Of cause, such files can be generate if a pattern is agreed.

just my 2 cents,
 wh
_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
[prev in list] [next in list] [prev in thread] [next in thread]