[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg-devel
Subject:    Re: [PATCH] Add a return value to set_cursor_position() to allow it to report failure
From:       Keith Packard <keithp () keithp ! com>
Date:       2014-04-30 17:23:37
Message-ID: 8661lqvihy.fsf () hiro ! keithp ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Michael Thayer <michael.thayer@oracle.com> writes:

> On 22/04/14 07:00, Keith Packard wrote:
>> Michael Thayer <michael.thayer@oracle.com> writes:
>>
>>> set_cursor_position() may need to be able to fail and have the server fall
>>> back to a software cursor in at least the situation in which we are running
>>> on virtual hardware and using the host cursor as a hardware cursor for the
>>> guest but cannot change its position.
>>
>> Frankly, the usual "solution" for nested or virtual X servers is to just
>> ignore the cursor position assignment.
>
> I would still very much like to have the change if it considered 
> acceptable, and can submit an fixed patch like the one for 
> set_cursor_argb() and friends to force a driver build break.  Of course 
> if you tell me it is something that you would rather not have in I can 
> leave it at that.

I don't see any value in allowing pointer warping to fail and setting a
software cursor in response. If the next input event from the user isn't
going to happen at the warped position, then you should be setting the
cursor position before sending the next input event anyways.

The alternative is for you to simply always use a software cursor, which
would be easy to manage.

-- 
keith.packard@intel.com

[Attachment #5 (application/pgp-signature)]

_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

[prev in list] [next in list] [prev in thread] [next in thread]