[prev in list] [next in list] [prev in thread] [next in thread]
List: freedesktop-xorg-devel
Subject: Re: [PATCH RESEND] xfree86: fix "No devices detected" error for non-seat0 seats (#66851)
From: Dave Airlie <airlied () gmail ! com>
Date: 2014-01-31 22:11:43
Message-ID: CAPM=9tx2PAw2ikotjVRwEraNVLprOqdSU25fcBpyX5-89LsAvA () mail ! gmail ! com
[Download RAW message or body]
On Fri, Jan 31, 2014 at 9:19 PM, Laércio de Sousa <lbsousajr@gmail.com> wrote:
> This fixes a bug that prevents X.Org from starting properly on,
> e.g., NVIDIA cards with proprietary drivers, when "-seat" option
> is passed with an argument different from "seat0".
Do nvidia cards with the binary driver work in other seats? I can't
imagine they would since the drivers don't integrate with udev etc.
Dave.
>
> Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=66851
>
> Signed-off-by: Laércio de Sousa <lbsousajr@gmail.com>
> ---
> hw/xfree86/common/xf86Bus.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/xfree86/common/xf86Bus.c b/hw/xfree86/common/xf86Bus.c
> index 329d0b3..23dfa37 100644
> --- a/hw/xfree86/common/xf86Bus.c
> +++ b/hw/xfree86/common/xf86Bus.c
> @@ -81,7 +81,7 @@ xf86CallDriverProbe(DriverPtr drv, Bool detect_only)
> if (drv->platformProbe != NULL) {
> foundScreen = xf86platformProbeDev(drv);
> }
> - if (ServerIsNotSeat0())
> + if (ServerIsNotSeat0() && foundScreen)
> return foundScreen;
> #endif
>
> @@ -201,7 +201,7 @@ xf86BusProbe(void)
> {
> #ifdef XSERVER_PLATFORM_BUS
> xf86platformProbe();
> - if (ServerIsNotSeat0())
> + if (ServerIsNotSeat0() && xf86_num_platform_devices > 0)
> return;
> #endif
> #ifdef XSERVER_LIBPCIACCESS
> --
> 1.8.1.4
>
> _______________________________________________
> xorg-devel@lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic