[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg-devel
Subject:    Re: [PULL] Fix Damage protocol for Xinerama
From:       Keith Packard <keithp () keithp ! com>
Date:       2013-10-31 22:57:46
Message-ID: 86r4b1121h.fsf () miki ! keithp ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

Content-Transfer-Encoding: quoted-printable

Adam Jackson <ajax@redhat.com> writes:

> Same as the v5 series I sent a bit ago.  2 and 3 aren't reviewed yet,
> though 2 is at least trivial.  Tested against the nvidia driver and
> against a hacked Xvfb, both root and toplevel reports appear to be sane
> now, and Subtracts are clipped to the (logical) root window.
>
> Sadly this does not result in, say, 'xcompmgr -n' drawing what you'd
> expect.  This appears to be due to bugs outside the Damage extension
> proper, which I'm still looking into, but at least the protocol is
> closer to correct.  (xcompmgr -a _does_ work, but that's not entirely
> surprising, the cm doesn't actually do any work in that case and no
> Damage protocol is ever generated.)
>
> The following changes since commit 902ff0b3497d202b86bf9a411e17db7b694d6eaa:
>
>   xfree86: Bump video/input/extension ABIs for 1.15 (2013-10-30 14:02:59 -0700)
>
> are available in the git repository at:
>
>   ssh://people.freedesktop.org/~ajax/xserver.git dx-final
>
> for you to fetch changes up to d62e943382773ed9c27f7508b684d3a2d0b8030f:
>
>   damageext: Xineramify (v5) (2013-10-31 16:26:02 -0400)
>
> ----------------------------------------------------------------
> Adam Jackson (3):
>       xinerama: Export the screen region
>       dix: Add PostDispatchCallback
>       damageext: Xineramify (v5)

I thought the plan for DamageSubtract was to take the union of the
window regions and intersect with that? As it is, you're doing an
intersect with the screen region (which is in screen space) with the
damage region (which is in window space).

-- 
keith.packard@intel.com

[Attachment #5 (application/pgp-signature)]

_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

[prev in list] [next in list] [prev in thread] [next in thread]