[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg-devel
Subject:    Re: [PATCH 12/12] dri2: Don't bother with xf86LoaderCheckSymbol("DRI2Connect")
From:       Ian Romanick <idr () freedesktop ! org>
Date:       2012-10-29 18:12:34
Message-ID: 508EC712.9040300 () freedesktop ! org
[Download RAW message or body]

On 10/16/2012 11:56 AM, Adam Jackson wrote:
> The DRI2 code is now built-in to the server, even for Xorg.  The only
> thing this could protect against is trying to run a libglx built with
> DRI2 support against an Xorg built without it, which is firmly in
> "doctor it hurts when I do this" territory.
>
> Signed-off-by: Adam Jackson <ajax@redhat.com>

This patch is:

Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>

> ---
>   glx/glxdri2.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/glx/glxdri2.c b/glx/glxdri2.c
> index 0ce40ca..e5efc31 100644
> --- a/glx/glxdri2.c
> +++ b/glx/glxdri2.c
> @@ -890,8 +890,7 @@ __glXDRIscreenProbe(ScreenPtr pScreen)
>       if (screen == NULL)
>           return NULL;
>
> -    if (!xf86LoaderCheckSymbol("DRI2Connect") ||
> -        !DRI2Connect(serverClient, pScreen, DRI2DriverDRI,
> +    if (!DRI2Connect(serverClient, pScreen, DRI2DriverDRI,
>                        &screen->fd, &driverName, &deviceName)) {
>           LogMessage(X_INFO,
>                      "AIGLX: Screen %d is not DRI2 capable\n", pScreen->myNum);
>

_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
[prev in list] [next in list] [prev in thread] [next in thread]