[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg-devel
Subject:    Re: [PATCH] randr: Fix REQUEST vs. REQUEST_SIZE_MATCH mismatch
From:       Aaron Plattner <aplattner () nvidia ! com>
Date:       2012-06-29 20:31:52
Message-ID: 4FEE10B8.7050203 () nvidia ! com
[Download RAW message or body]

On 06/29/2012 12:57 PM, Alan Coopersmith wrote:
> On 06/29/12 12:22 PM, Aaron Plattner wrote:
>> ProcRRGetScreenSizeRange uses REQUEST(xRRGetScreenSizeRangeReq) followed by
>> REQUEST_SIZE_MATCH(xRRGetScreenSizeRangeReq).  This happens to work out because

d'oh, this should read REQUEST_SIZE_MATCH(xRRGetScreenInfoReq), of course. 
Stupid copy & paste errors... :P

-- Aaron

>> both requests have the same size, so this is not a functional change, just a
>> cosmetic one.
>>
>> Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
>> ---
>>   randr/rrscreen.c |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/randr/rrscreen.c b/randr/rrscreen.c
>> index 55110e0..c564d1f 100644
>> --- a/randr/rrscreen.c
>> +++ b/randr/rrscreen.c
>> @@ -195,7 +195,7 @@ ProcRRGetScreenSizeRange(ClientPtr client)
>>       rrScrPrivPtr pScrPriv;
>>       int rc;
>>
>> -    REQUEST_SIZE_MATCH(xRRGetScreenInfoReq);
>> +    REQUEST_SIZE_MATCH(xRRGetScreenSizeRangeReq);
>>       rc = dixLookupWindow(&pWin, stuff->window, client, DixGetAttrAccess);
>>       if (rc != Success)
>>           return rc;
>
> Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
[prev in list] [next in list] [prev in thread] [next in thread]