[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg-devel
Subject:    Re: [PATCH synaptics 2/8] Removing extra call SetDeviceAndProtocol()
From:       Peter Hutterer <peter.hutterer () who-t ! net>
Date:       2011-02-28 3:21:05
Message-ID: 20110228032105.GD21365 () barra ! bne ! redhat ! com
[Download RAW message or body]

On Sun, Feb 27, 2011 at 01:11:45AM +0500, Alexandr Shadchin wrote:
> SetDeviceAndProtocol() calling in SynapticsPreInit(), extra calling
> in DeviceOn() unnecessary.
> 
> Signed-off-by: Alexandr Shadchin <Alexandr.Shadchin@gmail.com>
> ---
>  src/synaptics.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/src/synaptics.c b/src/synaptics.c
> index daa0542..b1d027f 100644
> --- a/src/synaptics.c
> +++ b/src/synaptics.c
> @@ -786,7 +786,6 @@ DeviceOn(DeviceIntPtr dev)
>  
>      DBG(3, "Synaptics DeviceOn called\n");
>  
> -    SetDeviceAndProtocol(pInfo);
>      pInfo->fd = xf86OpenSerial(pInfo->options);
>      if (pInfo->fd == -1) {
>  	xf86Msg(X_WARNING, "%s: cannot open input device\n", pInfo->name);
> -- 
> 1.7.3.5

Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>

Cheers,
  Peter
_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
[prev in list] [next in list] [prev in thread] [next in thread]