[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg-devel
Subject:    displayid: dubious assignments
From:       Nicolas Kaiser <nikai () nikai ! net>
Date:       2010-10-30 19:03:49
Message-ID: 20101030210349.2a1e0e79 () absol ! kitzblitz
[Download RAW message or body]

Hi there!

I noticed two assignments that look a bit peculiar to me.
n is assigned MAX_HSYNC and MAX_VREFRESH, but these values
get either overwritten or remain unused.
I hope that's not a problem?

hw/xfree86/modes/xf86DisplayIDModes.c +318
	    n = mon->nHsync++;
	    if (n < MAX_HSYNC) {
		mon->hsync[n].lo = x[9];
		mon->hsync[n].hi = x[10];
	    } else {
->		n = MAX_HSYNC;
	    }
->	    n = mon->nVrefresh++;
	    if (n < MAX_VREFRESH) {
		mon->vrefresh[n].lo = x[13];
		mon->vrefresh[n].hi = x[14];
	    } else {
->		n = MAX_VREFRESH;
	    }
->	    break;

Best regards,
Nicolas Kaiser
_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
[prev in list] [next in list] [prev in thread] [next in thread]