[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg-devel
Subject:    Re: [PATCH 0/6] fbdevhw cleanup and pciaccess free
From:       Mark Kettenis <mark.kettenis () xs4all ! nl>
Date:       2010-05-31 15:45:10
Message-ID: 201005311545.o4VFjA67024149 () glazunov ! sibelius ! xs4all ! nl
[Download RAW message or body]

> Date: Mon, 31 May 2010 18:06:02 +0300
> From: "Vignatti Tiago (Nokia-D/Helsinki)" <tiago.vignatti@nokia.com>
> 
> On Mon, May 31, 2010 at 05:04:37PM +0200, ext Mark Kettenis wrote:
> > > Date: Mon, 31 May 2010 17:42:51 +0300
> > > From: "Vignatti Tiago (Nokia-D/Helsinki)" <tiago.vignatti@nokia.com>
> > > 
> > > can you please point exactly where I'm polluting generic PCI
> > > code with Linux specific? I found your commentary pretty
> > > interesting because this is one of the problems I'm trying to
> > > address with the cleaning up patches I've been sending.
> > 
> > The bit below.
> 
> the reason for that is on the commit message. Or maybe I should be
> more clear?

Well, what's this "other story"?

Anyway, if you really insist on making "struct pci_device" opaque in
fbdevhw, you should add a function that returns the domain, bus,
device and function based on the passed "struct pci_device" pointer.
_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
[prev in list] [next in list] [prev in thread] [next in thread]