[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg-devel
Subject:    [PATCH] util-macros: Addition of a meta data file
From:       daniel () fooishbar ! org (Daniel Stone)
Date:       2009-11-29 4:19:28
Message-ID: 20091129041928.GA2320 () tempa
[Download RAW message or body]

On Fri, Nov 27, 2009 at 10:39:15AM -0800, Dan Nicholson wrote:
> On Fri, Nov 27, 2009 at 9:54 AM, Gaetan Nadon <gaetan.nadon at videotron.ca> wrote:
> > Thanks! That's an area I need to learn more about. I picked this line from
> > other .ac files. I'll make it a todo when I review those to make the
> > correction. I did replace "pkg-config" with the libtool env var in the hope
> > it would be more portable and/or safer.
> >
> > sdkdir=$(pkg-config --variable=sdkdir xorg-server)
> 
> This should be
> 
> sdkdir=`$PKG_CONFIG --variable=sdkdir xorg-server`
> 
> 1. The user may need to use a specific pkg-config or pass custom
> arguments to it. Think multiarch or cross-compiling scenarios.
> 
> 2. Backticks (``) are supported by all shells while $() command
> substitution is for strictly POSIX conforming shells. We don't need to
> limit ourselves to that subset.

Yeah, I wrote that bit originally, and those changes sound fine to me.

Cheers,
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
Url : http://lists.x.org/archives/xorg-devel/attachments/20091129/31fd9401/attachment-0001.pgp 

[prev in list] [next in list] [prev in thread] [next in thread]