[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg-devel
Subject:    [PATCH 1/4] Hide a number of private symbols
From:       Alan.Coopersmith () Sun ! COM (Alan Coopersmith)
Date:       2009-07-31 20:28:45
Message-ID: 4A7353FD.9000308 () sun ! com
[Download RAW message or body]



Thomas Dickey wrote:
> On Fri, 31 Jul 2009, Julien Cristau wrote:
> 
>> Add _X_HIDDEN for some symbols that aren't used outside of Xlib.
> 
> ...
> 
> xterm uses this, has used the specific Xlib.h interface since 1999.
> 
> There's a reason for having those in the header file (probably other
> programs than xterm use them ;-)
> 
> 
>> -KeySym
>> -XKeycodeToKeysym(Display *dpy,
> ...
> 
>> +#ifdef XKB
>> +_X_HIDDEN
>> +#endif
>> +KeySym
>> +XKeycodeToKeysym(Display *dpy,

Perhaps it would have been clearer with the other #ifdef XKB defines
expanded in place:

#ifdef XKB
_X_HIDDEN KeySym
_XKeycodeToKeysym
#else
KeySym
XKeycodeToKeysym
#endif
(Display *dpy, ....

-- 
	-Alan Coopersmith-           alan.coopersmith at sun.com
	 Sun Microsystems, Inc. - X Window System Engineering


[prev in list] [next in list] [prev in thread] [next in thread]