From freedesktop-dbus Fri Jun 09 00:10:12 2023 From: Thiago Macieira Date: Fri, 09 Jun 2023 00:10:12 +0000 To: freedesktop-dbus Subject: Re: Proper handling of the dbus call method timeout Message-Id: <3204913.AJdgDx1Vlc () tjmaciei-mobl5> X-MARC-Message: https://marc.info/?l=freedesktop-dbus&m=168626940725005 On Thursday, 8 June 2023 06:04:55 PDT Simon McVittie wrote: > * changing what happens when the maximum number of pending replies is > reached, so that instead of making the *newest* calls from the same > client fail, the dbus-daemon would make the *oldest* calls for the same > client (or maybe the same (client,service) pair) report a NoReply or > LimitsExceeded failure message synthesized by the dbus-daemon I don't think that's completely right. There may be many reasons why replies to newer messages are sent before older ones, so attempting to add this code, even if it kicks in only for when the maximum number of replies is reached, is potentially a source of bugs. The bug should be fixed where the bug is: in the daemon in question. -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel DCAI Cloud Engineering