[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-dbus
Subject:    Re: dbus_connection_send_with_reply_and_block and errors
From:       Colin Walters <walters () verbum ! org>
Date:       2005-08-09 18:12:24
Message-ID: 1123611144.26691.14.camel () nexus ! verbum ! private
[Download RAW message or body]


On Tue, 2005-08-09 at 21:02 +0300, Timo Teräs wrote:

> Not sure about this. But dbus_set_error does already allocate memory for
> the message field. 

You're right, looking at the code dbus_set_error just transforms the
error to OOM in that case, which surprised me at first but I guess it
makes sense.  Sorry about commenting without looking at that code.

> Yes. Now that I thinked more about this, it might be good to do the
> change in dbus_set_error() since most people will propably assume that
> it dups both fields. Atleast I thought so until I read the docs in more
> detail. So I agree with Havoc that doing assignment of .name in
> dbus_set_error() is a bad idea.
> 
> I'll do a patch for this and post it asap for review.

Ok.


["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]