[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-dev
Subject:    [cfe-dev] clang-format chromium ternary operator
From:       Thiago Farina <tfransosi () gmail ! com>
Date:       2013-08-10 19:06:30
Message-ID: CACnwZYcjU5m_DD_82+JUmgGRRA0D-N95iAsrE+puKO9fu9nFTw () mail ! gmail ! com
[Download RAW message or body]

Hi,

Looks like clang-format for Chromium style is incorrectly formatting
ternary operators (?:)

By Google C++ Style guide, which Chromium code follows:
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Boolean_Expressions#Boolean_Expressions


The operators should be in the end of the expressions.

But clang-format did this:
https://codereview.chromium.org/21696003/diff/35001/chrome/browser/ui/views/location_bar/location_bar_view.cc#newcode1107


According to the style guide and Peter it should have been formatted like this:

return (ui::GetDisplayLayout() == ui::LAYOUT_TOUCH) ?
    GetItemPadding() / 2 : 0;

--
Thiago
_______________________________________________
cfe-dev mailing list
cfe-dev@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev


[prev in list] [next in list] [prev in thread] [next in thread]