[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    Re: [PATCH] Fix crash when assiging to a property with an invalid type
From:       jahanian <fjahanian () apple ! com>
Date:       2014-07-30 21:02:51
Message-ID: FF95E444-EAEA-4B1E-B05B-99A43A231B10 () apple ! com
[Download RAW message or body]


On Jul 30, 2014, at 1:43 PM, jahanian <fjahanian@apple.com> wrote:

> 
> On Jul 30, 2014, at 1:21 PM, Olivier Goffart <ogoffart@kde.org> wrote:
> 
>> It does crash for me (linux, r214316).
>> In debug mode, there is an assert. In release mode it segfaults.
> 
> Strange, I tested it against a debuggable compiler (with assert on). 
> Let me investigate a bit more why it doesn’t crash for me.

OK. I missed that it was an ObjectiveC++ test. Both patches look good to me.
- Fariborz

> 
> - Fariborz
> 
>> 
>> -- 
>> Olivier
>> 
>> On Wednesday 30 July 2014 09:14:09 jahanian wrote:
>>> I don’t see a crash with TOT clang:
>>> 
>>> t.m:3:3: error: unknown type name 'A'
>>> A* response; // expected-error {{unknown type name 'A'}}
>>> ^
>>> t.m:8:11: error: unknown type name 'A'
>>> @property A* response;  // expected-error {{unknown type name 'A'}}
>>>         ^
>>> t.m:13:16: error: expected a type
>>> - (void) foo :(A*) a   // expected-error {{expected a type}}
>>>              ^
>>> t.m:15:17: error: assignment to readonly property
>>> self.response = a;
>>> ~~~~~~~~~~~~~ ^ ~
>>> 4 errors generated.
>>> 
>>> - Fariborz
>>> 
>>> On Jul 30, 2014, at 12:42 AM, Olivier Goffart <ogoffart@kde.org> wrote:
>>>> Hi,
>>>> 
>>>> Attached you will find a fix for a crash I have when parsing objective C
>>>> with missing include.
>>>> This is a regression against clang 3.4 which did not crash.
>>>> 
>>>> My approach here is naive and just fixes the symptoms (the crash).
>>>> 
>>>> Regards
>> 
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits@cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits


_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
[prev in list] [next in list] [prev in thread] [next in thread]