[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request 122153: KD Chart
From: Jarosław_Staniek <staniek () kde ! org>
Date: 2016-01-16 0:31:19
Message-ID: 20160116003119.32176.47902 () mimi ! kde ! org
[Download RAW message or body]
--===============3525195790364038247==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122153/#review91168
-----------------------------------------------------------
@Friedrich What to do with this patch? Is it needed now or?
- Jarosław Staniek
On Dec. 3, 2015, 8:58 a.m., Stephen Leibowitz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122153/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2015, 8:58 a.m.)
>
>
> Review request for Calligra and Jarosław Staniek.
>
>
> Repository: calligra
>
>
> Description
> -------
>
> These patches are also being made at kdab.com. Those who have a KDAB account can \
> see the discussion in "Suggested Changes to KD Chart" at \
> https://quality.kdab.com/browse/KDCH-1020
> Calligra's kdchart and kdgantt files are out-of-date, even with the patches from \
> the above paragraph. For example, "Compiler warnings" at \
> http://mail.kde.org/pipermail/calligra-devel/2015-January/012762.html mentioned an \
> error in KDChartPieDiagram.cpp. But the error is in a private function that was \
> removed from the latest version (2.5.1) of KD Chart. KDAB will not patch previous \
> versions. See "PieDiagram::drawPieSurface" at \
> https://quality.kdab.com/browse/KDCH-1023
> KDAB makes available source code for the latest and earlier versions of its KD \
> Chart and other GPL licensed software at http://docs.kdab.com/
>
> Diffs
> -----
>
> 3rdparty/kdchart/src/KDChartLayoutItems.cpp 095d2cd
> 3rdparty/kdchart/src/KDChartStockDiagram_p.cpp d8636d7
>
> Diff: https://git.reviewboard.kde.org/r/122153/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Stephen Leibowitz
>
>
--===============3525195790364038247==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122153/">https://git.reviewboard.kde.org/r/122153/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">@Friedrich What to do with this patch? Is it needed now or?</p></pre> <br \
/>
<p>- Jarosław Staniek</p>
<br />
<p>On December 3rd, 2015, 8:58 a.m. CET, Stephen Leibowitz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Calligra and Jarosław Staniek.</div>
<div>By Stephen Leibowitz.</div>
<p style="color: grey;"><i>Updated Dec. 3, 2015, 8:58 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">These patches are also being made at kdab.com. Those \
who have a KDAB account can see the discussion in "Suggested Changes to KD Chart" at \
https://quality.kdab.com/browse/KDCH-1020</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Calligra's kdchart and \
kdgantt files are out-of-date, even with the patches from the above paragraph. For \
example, "Compiler warnings" at \
http://mail.kde.org/pipermail/calligra-devel/2015-January/012762.html mentioned an \
error in KDChartPieDiagram.cpp. But the error is in a private function that was \
removed from the latest version (2.5.1) of KD Chart. KDAB will not patch previous \
versions. See "PieDiagram::drawPieSurface" at \
https://quality.kdab.com/browse/KDCH-1023</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">KDAB makes available \
source code for the latest and earlier versions of its KD Chart and other GPL \
licensed software at http://docs.kdab.com/</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>3rdparty/kdchart/src/KDChartLayoutItems.cpp <span style="color: \
grey">(095d2cd)</span></li>
<li>3rdparty/kdchart/src/KDChartStockDiagram_p.cpp <span style="color: \
grey">(d8636d7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122153/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3525195790364038247==--
[Attachment #3 (text/plain)]
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic