'Re: Review Request 123699: Changed a few labels in kexi's forms and reports designers'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Review Request 123699: Changed a few labels in kexi's forms and reports designers
From:       Jarosław_Staniek <staniek () kde ! org>
Date:       2016-01-15 22:20:59
Message-ID: 20160115222059.32176.42584 () mimi ! kde ! org
[Download RAW message or body]

--===============2069771188910141747==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123699/#review91165
-----------------------------------------------------------

Ship it!

Ship It!

- Jarosław Staniek

On May 9, 2015, 1:24 p.m., Karol Pawlowski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123699/
> -----------------------------------------------------------
> 
> (Updated May 9, 2015, 1:24 p.m.)
> 
> 
> Review request for Calligra, Jarosław Staniek and Wojciech Kosowicz.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Small improvements to kexi forms and reports. Tasks 4th, 9th and 10th from \
> https://community.kde.org/Kexi/Junior_Jobs/Small_report_improvements 
> - Rename visible caption of "Web" to "Web Page" ("Check" to "Check Box" was done \
>                 previously)
> - Change label for the data source combo in report designer's "Internal Source" to \
>                 "Report's data source:"
> - Change label in form designer's 'data source' tab from "Form's data source" to \
> "Form's data source:". Also in report designer's 'data source' tab change "Source \
> Type:" to "Source type:" and "External Source:" to "External source:". 
> 
> Diffs
> -----
> 
> kexi/plugins/forms/kexidatasourcepage.cpp 82bb7b4 
> kexi/plugins/forms/kexiformmanager.cpp 6906b00 
> kexi/plugins/reports/kexisourceselector.cpp edf02eb 
> plugins/reporting/web/KoReportWebPlugin.cpp 145e987 
> 
> Diff: https://git.reviewboard.kde.org/r/123699/diff/
> 
> 
> Testing
> -------
> 
> See that labels are really changed as requested
> 
> 
> Thanks,
> 
> Karol Pawlowski
> 
> 

--===============2069771188910141747==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123699/">https://git.reviewboard.kde.org/r/123699/</a>
  </td>
    </tr>
   </table>
   <br />

<p>

Ship it!

</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Jarosław Staniek</p>

<br />
<p>On May 9th, 2015, 1:24 p.m. CEST, Karol Pawlowski wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Calligra, Jarosław Staniek and Wojciech Kosowicz.</div>
<div>By Karol Pawlowski.</div>

<p style="color: grey;"><i>Updated May 9, 2015, 1:24 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Small improvements to kexi forms and reports. Tasks \
4th, 9th and 10th from \
https://community.kde.org/Kexi/Junior_Jobs/Small_report_improvements</p> <ul \
style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: \
inherit;white-space: normal;"> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">Rename visible caption of "Web" to "Web \
Page" ("Check" to "Check Box" was done previously)</li> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Change \
label for the data source combo in report designer's "Internal Source" to "Report's \
data source:"</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">Change label in form designer's 'data \
source' tab from "Form's data source" to "Form's data source:". Also in report \
designer's 'data source' tab change "Source Type:" to "Source type:" and "External \
Source:" to "External source:".</li> </ul></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">See that labels are really changed as \
requested</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kexi/plugins/forms/kexidatasourcepage.cpp <span style="color: \
grey">(82bb7b4)</span></li>

 <li>kexi/plugins/forms/kexiformmanager.cpp <span style="color: \
grey">(6906b00)</span></li>

 <li>kexi/plugins/reports/kexisourceselector.cpp <span style="color: \
grey">(edf02eb)</span></li>

 <li>plugins/reporting/web/KoReportWebPlugin.cpp <span style="color: \
grey">(145e987)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123699/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============2069771188910141747==--

[Attachment #3 (text/plain)]

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 