[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request 117035: Kexi quickform QML plugin
From: Jarosław_Staniek <staniek () kde ! org>
Date: 2016-01-15 8:16:33
Message-ID: 20160115081633.21903.65145 () mimi ! kde ! org
[Download RAW message or body]
--===============5130169641208869446==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Jan. 15, 2016, 8:59 a.m., Jarosław Staniek wrote:
> > The idea is great and valid.
> >
> > I propose to drop this patch and keep the idea and old code around. QQ1 is \
> > dead...
>
> Adam Pigg wrote:
> a rewrite is partf my sailfish master plan
That's good. I was asking for closing because we're moving away from reviewboard and \
other systems for simplicity of our workflow.
- Jarosław
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117035/#review91127
-----------------------------------------------------------
On March 24, 2014, 10:44 p.m., Adam Pigg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117035/
> -----------------------------------------------------------
>
> (Updated March 24, 2014, 10:44 p.m.)
>
>
> Review request for Calligra and Jarosław Staniek.
>
>
> Repository: calligra
>
>
> Description
> -------
>
> Implement a QML plugin for Kexi which allows the user to write complex forms in \
> Kexi using QtQuick 1.
> Review is for comment on the concept and current implementation, not necessarily \
> for pushing just yet
>
> Diffs
> -----
>
> kexi/plugins/quickforms/quickrecord.cpp b075c3439b9dfb808527c549a69e681fbc9498ee
> kexi/plugins/quickforms/quickrecordset.h a47e7537088359a7ff94899df6812fb48a6d78ea
> kexi/plugins/quickforms/quickrecordset.cpp 0cb96ff1678567f0cabc59e69af5efa2e0b08c1b \
> kexi/plugins/quickforms/quickformview.cpp c39bf3707f0b1427a0364294313bc832478f975e \
> kexi/plugins/quickforms/quickrecord.h 47fe84f4b44df7ed8afbf92d61a0d9cc9a68182a
> kexi/plugins/quickforms/quickformpart.cpp d5985ea276447a689bed77189b04b90bc9351ef4
> kexi/plugins/quickforms/quickformview.h fa1728874df7a544b8b6c4f26a745c36ee747b10
> kexi/plugins/quickforms/quickformdesignview.cpp \
> 8386ce2d0cc08015c0dde1a0f3c7079228eb861c kexi/plugins/quickforms/quickformpart.h \
> 1853e69a784cc471f39337bbde046b94fbe81756 \
> kexi/plugins/quickforms/quickformdataview.h \
> a9493cd1f1508d21452cf55fedebd099379987ff \
> kexi/plugins/quickforms/quickformdataview.cpp \
> 3a65c7d6f1ad779148b4695ee6a3fd87ee1323be \
> kexi/plugins/quickforms/quickformdesignview.h \
> 893769fd835896b9758a59c62f105c42959ddd90 kexi/plugins/CMakeLists.txt \
> 431ba81f42d03b9d71cb5b497c6f14ee9d11dc05 kexi/plugins/quickforms/CMakeLists.txt \
> 45102f94debdcce90325771085d384b2ed9ba351 kexi/plugins/quickforms/kexiquickform.cpp \
> 00fe3ab12568fa637f146428f3369f2a9ac3f7d6 \
> kexi/plugins/quickforms/kexiquickformhandler.desktop \
> 74c21bdc8e2af49fb54eb55420939b1d8c691d44 \
> kexi/plugins/quickforms/kexiscriptadapterq.h \
> 71a0f51015a9691a9c76f48f181f1b32b4c674be \
> kexi/plugins/quickforms/kexiscriptadapterq.cpp \
> ee8467b6e89a7470ecf37ae06880e646657a962e
> Diff: https://git.reviewboard.kde.org/r/117035/diff/
>
>
> Testing
> -------
>
> Created test database with a few forms (attached)
>
>
> File Attachments
> ----------------
>
> test database
> https://git.reviewboard.kde.org/media/uploaded/files/2014/03/24/e771abd9-7af6-4d97-bb19-75737551488a__usda.kexi
>
>
> Thanks,
>
> Adam Pigg
>
>
--===============5130169641208869446==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117035/">https://git.reviewboard.kde.org/r/117035/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 15th, 2016, 8:59 a.m. CET, <b>Jarosław \
Staniek</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The idea is great and valid.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
propose to drop this patch and keep the idea and old code around. QQ1 is \
dead...</p></pre> </blockquote>
<p>On January 15th, 2016, 9:02 a.m. CET, <b>Adam Pigg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">a \
rewrite is partf my sailfish master plan</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">That's good. I was asking for closing because we're moving away from \
reviewboard and other systems for simplicity of our workflow.</p></pre> <br />
<p>- Jarosław</p>
<br />
<p>On March 24th, 2014, 10:44 p.m. CET, Adam Pigg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Calligra and Jarosław Staniek.</div>
<div>By Adam Pigg.</div>
<p style="color: grey;"><i>Updated March 24, 2014, 10:44 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Implement a QML plugin for Kexi which allows the user to write complex \
forms in Kexi using QtQuick 1.
Review is for comment on the concept and current implementation, not necessarily for \
pushing just yet</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Created test database with a few forms (attached)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/plugins/quickforms/quickrecord.cpp <span style="color: \
grey">(b075c3439b9dfb808527c549a69e681fbc9498ee)</span></li>
<li>kexi/plugins/quickforms/quickrecordset.h <span style="color: \
grey">(a47e7537088359a7ff94899df6812fb48a6d78ea)</span></li>
<li>kexi/plugins/quickforms/quickrecordset.cpp <span style="color: \
grey">(0cb96ff1678567f0cabc59e69af5efa2e0b08c1b)</span></li>
<li>kexi/plugins/quickforms/quickformview.cpp <span style="color: \
grey">(c39bf3707f0b1427a0364294313bc832478f975e)</span></li>
<li>kexi/plugins/quickforms/quickrecord.h <span style="color: \
grey">(47fe84f4b44df7ed8afbf92d61a0d9cc9a68182a)</span></li>
<li>kexi/plugins/quickforms/quickformpart.cpp <span style="color: \
grey">(d5985ea276447a689bed77189b04b90bc9351ef4)</span></li>
<li>kexi/plugins/quickforms/quickformview.h <span style="color: \
grey">(fa1728874df7a544b8b6c4f26a745c36ee747b10)</span></li>
<li>kexi/plugins/quickforms/quickformdesignview.cpp <span style="color: \
grey">(8386ce2d0cc08015c0dde1a0f3c7079228eb861c)</span></li>
<li>kexi/plugins/quickforms/quickformpart.h <span style="color: \
grey">(1853e69a784cc471f39337bbde046b94fbe81756)</span></li>
<li>kexi/plugins/quickforms/quickformdataview.h <span style="color: \
grey">(a9493cd1f1508d21452cf55fedebd099379987ff)</span></li>
<li>kexi/plugins/quickforms/quickformdataview.cpp <span style="color: \
grey">(3a65c7d6f1ad779148b4695ee6a3fd87ee1323be)</span></li>
<li>kexi/plugins/quickforms/quickformdesignview.h <span style="color: \
grey">(893769fd835896b9758a59c62f105c42959ddd90)</span></li>
<li>kexi/plugins/CMakeLists.txt <span style="color: \
grey">(431ba81f42d03b9d71cb5b497c6f14ee9d11dc05)</span></li>
<li>kexi/plugins/quickforms/CMakeLists.txt <span style="color: \
grey">(45102f94debdcce90325771085d384b2ed9ba351)</span></li>
<li>kexi/plugins/quickforms/kexiquickform.cpp <span style="color: \
grey">(00fe3ab12568fa637f146428f3369f2a9ac3f7d6)</span></li>
<li>kexi/plugins/quickforms/kexiquickformhandler.desktop <span style="color: \
grey">(74c21bdc8e2af49fb54eb55420939b1d8c691d44)</span></li>
<li>kexi/plugins/quickforms/kexiscriptadapterq.h <span style="color: \
grey">(71a0f51015a9691a9c76f48f181f1b32b4c674be)</span></li>
<li>kexi/plugins/quickforms/kexiscriptadapterq.cpp <span style="color: \
grey">(ee8467b6e89a7470ecf37ae06880e646657a962e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117035/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/03/24/e771abd9-7af6-4d97-bb19-75737551488a__usda.kexi">test \
database</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5130169641208869446==--
[Attachment #3 (text/plain)]
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic