'Re: Review Request 125493: PictureShapeConfigWidget: add error handling to KIO::Job.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Review Request 125493: PictureShapeConfigWidget: add error handling to KIO::Job.
From:       "Boudewijn Rempt" <boud () valdyas ! org>
Date:       2015-10-05 10:30:04
Message-ID: 20151005103004.17685.39870 () mimi ! kde ! org
[Download RAW message or body]

--===============8413311427400724695==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125493/#review86367
-----------------------------------------------------------

Ship it!

Sorry, was waiting for Zagge. Please push, I'll forward to master. There might \
actually be exactly the same issue in the VectorShape and in the VideoShape...

- Boudewijn Rempt

On Oct. 5, 2015, 10:22 a.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125493/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2015, 10:22 a.m.)
> 
> 
> Review request for Calligra, Boudewijn Rempt and Thorsten Zachmann.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Mistyping a filename in the file widget would lead to the job failing silently
> and the rest of the code trying to load an empty bytearray as the image data.
> 
> Better show a msgbox on error and delete the shape.
> 
> But this is last resort (e.g. remote URL and lost internet during transfer),
> see next commit.
> 
> 
> Diffs
> -----
> 
> plugins/pictureshape/PictureShapeConfigWidget.h \
> 14b59aaf749b335a3f69b075a8422732664f0ecb  \
> plugins/pictureshape/PictureShapeConfigWidget.cpp \
> e8cf8ccff228aa7a50a6ec58a2a1df7ede1a2ee0  
> Diff: https://git.reviewboard.kde.org/r/125493/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Faure
> 
> 

--===============8413311427400724695==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125493/">https://git.reviewboard.kde.org/r/125493/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Sorry, was waiting for Zagge. Please push, I'll forward to master. There \
might actually be exactly the same issue in the VectorShape and in the \
VideoShape...</p></pre>  <br />

<p>- Boudewijn Rempt</p>

<br />
<p>On October 5th, 2015, 10:22 a.m. UTC, David Faure wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Calligra, Boudewijn Rempt and Thorsten Zachmann.</div>
<div>By David Faure.</div>

<p style="color: grey;"><i>Updated Oct. 5, 2015, 10:22 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Mistyping a filename in the file widget would lead to the job failing \
silently and the rest of the code trying to load an empty bytearray as the image \
data.

Better show a msgbox on error and delete the shape.

But this is last resort (e.g. remote URL and lost internet during transfer),
see next commit.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plugins/pictureshape/PictureShapeConfigWidget.h <span style="color: \
grey">(14b59aaf749b335a3f69b075a8422732664f0ecb)</span></li>

 <li>plugins/pictureshape/PictureShapeConfigWidget.cpp <span style="color: \
grey">(e8cf8ccff228aa7a50a6ec58a2a1df7ede1a2ee0)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125493/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8413311427400724695==--

[Attachment #3 (text/plain)]

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 