[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request 125486: Fix crash when typing a bogus color-set name in the color set dialog.
From: "Boudewijn Rempt" <boud () valdyas ! org>
Date: 2015-10-02 21:00:27
Message-ID: 20151002210027.27965.12920 () mimi ! kde ! org
[Download RAW message or body]
--===============5892422129662781699==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125486/#review86253
-----------------------------------------------------------
Ship it!
Please push, I'll merge to master and krita-next.
- Boudewijn Rempt
On Oct. 2, 2015, 8:56 p.m., David Faure wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125486/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2015, 8:56 p.m.)
>
>
> Review request for Calligra and Thorsten Zachmann.
>
>
> Repository: calligra
>
>
> Description
> -------
>
> Fix crash when typing a bogus color-set name in the color set dialog.
>
>
> Diffs
> -----
>
> libs/widgets/KoColorSetWidget.cpp 5417c597f8e9486a46ec9461157252312da49726
>
> Diff: https://git.reviewboard.kde.org/r/125486/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Faure
>
>
--===============5892422129662781699==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125486/">https://git.reviewboard.kde.org/r/125486/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Please push, I'll merge to master and krita-next.</p></pre> <br />
<p>- Boudewijn Rempt</p>
<br />
<p>On October 2nd, 2015, 8:56 p.m. UTC, David Faure wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Calligra and Thorsten Zachmann.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated Oct. 2, 2015, 8:56 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix crash when typing a bogus color-set name in the color set \
dialog.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/widgets/KoColorSetWidget.cpp <span style="color: \
grey">(5417c597f8e9486a46ec9461157252312da49726)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125486/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5892422129662781699==--
[Attachment #3 (text/plain)]
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic