'Re: Review Request 124927: Fix encoding of import filters for Applix* files'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Review Request 124927: Fix encoding of import filters for Applix* files
From:       "Boudewijn Rempt" <boud () valdyas ! org>
Date:       2015-08-26 7:12:35
Message-ID: 20150826071235.4103.38303 () mimi ! kde ! org
[Download RAW message or body]

--===============9106532926296623237==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124927/#review84386
-----------------------------------------------------------

Sounds like the applix filter got broken then :-(

- Boudewijn Rempt

On Aug. 26, 2015, 12:03 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124927/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2015, 12:03 a.m.)
> 
> 
> Review request for Calligra and David Faure.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> The sources files of the Applix* import filters had been stored in iso8859-15. In \
> the methods to convert characters from Applix-style encoding to a QChar the mapping \
> was done by assigning respective `char`s to a QChar, with the `char`s mostly being \
> in the upper half of the iso8859-15 table. Not sure if this ever worked in Qt4 \
> (perhaps worked with older Qt), at least the docu does not really tell what decoder \
> is used for the `QChar(char ch)` constructor. 
> So this patch converts the source files to UTF-8 and also changes the values used \
> for mapping to the Unicode code point code. Compiles at leas here :) And my sample \
> aw files still are imported with same quality as before. Just, they all seem to \
> lack any non-latin1 characters, so I cannot test how the filters changed to . \
> Experimented with manual editing of the raw aw files, but not sure if I fooled \
> myself, so would prefer real files. 
> David, you are the only one known with access to ApplixWords/ApplixSpread, could \
> you tell if this patch improves or breaks things? (The .aw files created with \
> AbiWord for tests sadly seem all to be imported as empty documents always, no idea \
> why) 
> 
> Diffs
> -----
> 
> filters/sheets/applixspread/applixspreadimport.cc d3db02a 
> filters/words/applixword/applixwordimport.cc c890cfa 
> 
> Diff: https://git.reviewboard.kde.org/r/124927/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
> 

--===============9106532926296623237==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124927/">https://git.reviewboard.kde.org/r/124927/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Sounds like the applix filter got broken then :-(</p></pre>  <br />

<p>- Boudewijn Rempt</p>

<br />
<p>On August 26th, 2015, 12:03 a.m. UTC, Friedrich W. H. Kossebau wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Calligra and David Faure.</div>
<div>By Friedrich W. H. Kossebau.</div>

<p style="color: grey;"><i>Updated Aug. 26, 2015, 12:03 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The sources files of the Applix* import filters had \
been stored in iso8859-15. In the methods to convert characters from Applix-style \
encoding to a QChar the mapping was done by assigning respective <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">char</code>s to a QChar, with the <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">char</code>s mostly being in the upper half of the \
iso8859-15 table. Not sure if this ever worked in Qt4 (perhaps worked with older Qt), \
at least the docu does not really tell what decoder is used for the <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">QChar(char ch)</code> constructor.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So \
this patch converts the source files to UTF-8 and also changes the values used for \
mapping to the Unicode code point code. Compiles at leas here :) And my sample aw \
files still are imported with same quality as before. Just, they all seem to lack any \
non-latin1 characters, so I cannot test how the filters changed to . Experimented \
with manual editing of the raw aw files, but not sure if I fooled myself, so would \
prefer real files.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">David, you are the only one known with \
access to ApplixWords/ApplixSpread, could you tell if this patch improves or breaks \
things? (The .aw files created with AbiWord for tests sadly seem all to be imported \
as empty documents always, no idea why)</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>filters/sheets/applixspread/applixspreadimport.cc <span style="color: \
grey">(d3db02a)</span></li>

 <li>filters/words/applixword/applixwordimport.cc <span style="color: \
grey">(c890cfa)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124927/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============9106532926296623237==--

[Attachment #3 (text/plain)]

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 