[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request 124278: Improve Krita input device switching for Surface Pro 3
From: "Boudewijn Rempt" <boud () valdyas ! org>
Date: 2015-07-07 17:34:19
Message-ID: 20150707173419.16549.61125 () mimi ! kde ! org
[Download RAW message or body]
--===============0842390944830717658==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124278/#review82189
-----------------------------------------------------------
sure, go ahead!
- Boudewijn Rempt
On July 7, 2015, 4:18 p.m., Michael Abrahams wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124278/
> -----------------------------------------------------------
>
> (Updated July 7, 2015, 4:18 p.m.)
>
>
> Review request for Calligra.
>
>
> Bugs: 341899
> http://bugs.kde.org/show_bug.cgi?id=341899
>
>
> Repository: calligra
>
>
> Description
> -------
>
> This patch rewrites most of kis_tablet_support_win.cpp to support basic
> use of the eraser key on the Surface Pro 3.
>
> https://phabricator.kde.org/D146
>
> I'll close this once the issues are solved.
>
>
> Diffs
> -----
>
> krita/ui/input/wintab/kis_screen_size_choice_dialog.cpp 364419b
> krita/ui/input/wintab/kis_tablet_support.h 8c1b279
> krita/ui/input/wintab/kis_tablet_support_win.cpp 5e5d82f
> libs/flake/KoToolManager.cpp 731faed
>
> Diff: https://git.reviewboard.kde.org/r/124278/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Abrahams
>
>
--===============0842390944830717658==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124278/">https://git.reviewboard.kde.org/r/124278/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">sure, \
go ahead!</p></pre> <br />
<p>- Boudewijn Rempt</p>
<br />
<p>On July 7th, 2015, 4:18 p.m. UTC, Michael Abrahams wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Calligra.</div>
<div>By Michael Abrahams.</div>
<p style="color: grey;"><i>Updated July 7, 2015, 4:18 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=341899">341899</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch rewrites most of kis_tablet_support_win.cpp \
to support basic use of the eraser key on the Surface Pro 3. </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">https://phabricator.kde.org/D146</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I'll close this once the issues are solved.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/ui/input/wintab/kis_screen_size_choice_dialog.cpp <span style="color: \
grey">(364419b)</span></li>
<li>krita/ui/input/wintab/kis_tablet_support.h <span style="color: \
grey">(8c1b279)</span></li>
<li>krita/ui/input/wintab/kis_tablet_support_win.cpp <span style="color: \
grey">(5e5d82f)</span></li>
<li>libs/flake/KoToolManager.cpp <span style="color: grey">(731faed)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124278/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0842390944830717658==--
[Attachment #3 (text/plain)]
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic