[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request 124042: Fix for KoResourceItemView flickering due to content resize and scrollbar
From: "Boudewijn Rempt" <boud () valdyas ! org>
Date: 2015-06-20 8:54:57
Message-ID: 20150620085457.31347.78879 () mimi ! kde ! org
[Download RAW message or body]
--===============4457561595964756102==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124042/#review81590
-----------------------------------------------------------
Ship it!
Ship It!
- Boudewijn Rempt
On June 20, 2015, 8:54 a.m., Stefano Bonicatti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124042/
> -----------------------------------------------------------
>
> (Updated June 20, 2015, 8:54 a.m.)
>
>
> Review request for Calligra.
>
>
> Bugs: 344968
> http://bugs.kde.org/show_bug.cgi?id=344968
>
>
> Repository: calligra
>
>
> Description
> -------
>
> When vertically resizing a KoResourceItemView and the vertical scrollbar appears, \
> the tiles that represents the items are resized to fit the viewport with their \
> width, but this also reduces their height making the scrollbar not needed again. \
> The scrollbar disappearing lets the viewport expand and so the tiles, in height, \
> making the scrollbar needed again and this loops forever generating a considerable \
> slowdown.
> The fix consists in always showing the vertical scrollbar so that no resizing \
> happens due to them. This is extended also in the other cases, where rows are fixed \
> and a horizontal scrollbar is used, or when scrollbar appearing should be dynamic.
> To avoid unnecessary work and event spam i've added check in \
> KoResourceItemChooser::setSynced function if the value passed corresponds to its \
> current status already.
> Fixed also a small typo while i was at it.
>
> Thanks to mmolch for pointing in the right direction with his patch.
>
> Now this patch is on review not only because changes a calligra class, but because \
> when a part of it was first proposed, it apparently still created some issues to \
> the bug reporter, so it would be better to test it more. \
> krita-presetdockerflickering-bonicatti branch contains this patch.
>
> Diffs
> -----
>
> libs/widgets/KoResourceItemChooser.cpp d1e3f89
> libs/widgets/KoResourceItemView.cpp f933b9c
>
> Diff: https://git.reviewboard.kde.org/r/124042/diff/
>
>
> Testing
> -------
>
> Tested resizing in the special condition and had no flickering or performance hit.
> The original bug reporter said that he was unable to properly resize the main krita \
> window (with XFCE), but i had none of those problems (using KDE).
>
> Thanks,
>
> Stefano Bonicatti
>
>
--===============4457561595964756102==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124042/">https://git.reviewboard.kde.org/r/124042/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Boudewijn Rempt</p>
<br />
<p>On June 20th, 2015, 8:54 a.m. UTC, Stefano Bonicatti wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Calligra.</div>
<div>By Stefano Bonicatti.</div>
<p style="color: grey;"><i>Updated June 20, 2015, 8:54 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=344968">344968</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">When vertically resizing a KoResourceItemView and the \
vertical scrollbar appears, the tiles that represents the items are resized to fit \
the viewport with their width, but this also reduces their height making the \
scrollbar not needed again. The scrollbar disappearing lets the viewport expand and \
so the tiles, in height, making the scrollbar needed again and this loops forever \
generating a considerable slowdown.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">The fix consists in \
always showing the vertical scrollbar so that no resizing happens due to them. This \
is extended also in the other cases, where rows are fixed and a horizontal scrollbar \
is used, or when scrollbar appearing should be dynamic.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">To \
avoid unnecessary work and event spam i've added check in \
KoResourceItemChooser::setSynced function if the value passed corresponds to its \
current status already.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Fixed also a small typo while i was at \
it.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Thanks to mmolch for pointing in the right direction \
with his patch.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Now this patch is on review not only \
because changes a calligra class, but because when a part of it was first proposed, \
it apparently still created some issues to the bug reporter, so it would be better to \
test it more. krita-presetdockerflickering-bonicatti branch contains this \
patch.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested resizing in the special condition and had no \
flickering or performance hit. The original bug reporter said that he was unable to \
properly resize the main krita window (with XFCE), but i had none of those problems \
(using KDE).</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/widgets/KoResourceItemChooser.cpp <span style="color: \
grey">(d1e3f89)</span></li>
<li>libs/widgets/KoResourceItemView.cpp <span style="color: \
grey">(f933b9c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124042/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4457561595964756102==--
[Attachment #3 (text/plain)]
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic