[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request 123981: Port words page settings dialog to KF5
From: "Boudewijn Rempt" <boud () valdyas ! org>
Date: 2015-06-02 9:00:23
Message-ID: 20150602090023.8350.39823 () mimi ! kde ! org
[Download RAW message or body]
--===============4147559669257676891==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123981/#review81070
-----------------------------------------------------------
I sort of suspect that the same change is needed across all Calligra applications -- \
everyone is using kpagedialog for the settings!
- Boudewijn Rempt
On June 1, 2015, 7:28 p.m., Peter Simonsson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123981/
> -----------------------------------------------------------
>
> (Updated June 1, 2015, 7:28 p.m.)
>
>
> Review request for Calligra.
>
>
> Repository: calligra
>
>
> Description
> -------
>
> New button settings and signals.
>
>
> Diffs
> -----
>
> words/part/KWView.cpp 6647e83
> words/part/dialogs/KWPageSettingsDialog.h 79e0d9d
> words/part/dialogs/KWPageSettingsDialog.cpp 43d1311
>
> Diff: https://git.reviewboard.kde.org/r/123981/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Peter Simonsson
>
>
--===============4147559669257676891==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123981/">https://git.reviewboard.kde.org/r/123981/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
sort of suspect that the same change is needed across all Calligra applications -- \
everyone is using kpagedialog for the settings!</p></pre> <br />
<p>- Boudewijn Rempt</p>
<br />
<p>On June 1st, 2015, 7:28 p.m. UTC, Peter Simonsson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Calligra.</div>
<div>By Peter Simonsson.</div>
<p style="color: grey;"><i>Updated June 1, 2015, 7:28 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">New button settings and signals.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>words/part/KWView.cpp <span style="color: grey">(6647e83)</span></li>
<li>words/part/dialogs/KWPageSettingsDialog.h <span style="color: \
grey">(79e0d9d)</span></li>
<li>words/part/dialogs/KWPageSettingsDialog.cpp <span style="color: \
grey">(43d1311)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123981/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4147559669257676891==--
[Attachment #3 (text/plain)]
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic