[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request 123952: Consistency: use ILIKE/NOT ILIKE operator instead of LIKE for PostgreSQL
From: Jarosław_Staniek <staniek () kde ! org>
Date: 2015-05-31 20:57:29
Message-ID: 20150531205729.8350.12295 () mimi ! kde ! org
[Download RAW message or body]
--===============1713615563890447538==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123952/
-----------------------------------------------------------
(Updated May 31, 2015, 8:57 p.m.)
Status
------
This change has been marked as submitted.
Review request for Calligra, Andrius da Costa Ribas, Kamil Łysik, Friedrich W. H. \
Kossebau, Adam Pigg, Roman Shtemberko, Radosław Wicik, and Wojciech Kosowicz.
Changes
-------
Submitted with commit 03b43ccbfd65c17362003047e7fec8ecef3c3bb7 by Jaroslaw Staniek to \
branch calligra/2.9.
Bugs: 348203
http://bugs.kde.org/show_bug.cgi?id=348203
Repository: calligra
Description
-------
Consistency: use ILIKE/NOT ILIKE operator instead of LIKE for PostgreSQL
This fixes the issue "PostgreSQL uses case-sensitive search for LIKE
SQL operator, Kexi's default is case-insensitive"
The approach isn't generic enough for other expressions (the context
of connection could be better) but it's already much better than ignoring
differences between servers.
Diffs
-----
kexi/kexidb/drivers/pqxx/pqxxdriver.cpp 83f655c56a7d58c6f0aca87786261d0a6571345a
kexi/plugins/queries/kexiquerydesignerguieditor.cpp \
2943df6bef7a08312ff19deeb2a146f1da0f450b \
kexi/widget/tableview/kexicomboboxpopup.cpp 1a0e0eca61f881e638242197dc6cbeef8c69200a \
libs/db/connection.cpp af245efb17345f515cde3b4457f74e59a849077d libs/db/driver.cpp \
c1277a8993ced0ec7e4019fed990df8d4a0f5d5f libs/db/driver_p.h \
4cdfb5bf051ba3888ffe96974eee19e18a22269c libs/db/expression.h \
a7b0410a6172c7cc662213f540497855a97501ee libs/db/expression.cpp \
794732ea12830dfd09aac4cd0c16675e1ab6fedb libs/db/parser/parser_p.cpp \
5f11f4ea8ce947bf3e4e9dfd97e5f259776fc90b
Diff: https://git.reviewboard.kde.org/r/123952/diff/
Testing
-------
Queries work now for pgsql as for sqlite/mysql
Thanks,
Jarosław Staniek
--===============1713615563890447538==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123952/">https://git.reviewboard.kde.org/r/123952/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Calligra, Andrius da Costa Ribas, Kamil Łysik, Friedrich W. \
H. Kossebau, Adam Pigg, Roman Shtemberko, Radosław Wicik, and Wojciech \
Kosowicz.</div> <div>By Jarosław Staniek.</div>
<p style="color: grey;"><i>Updated May 31, 2015, 8:57 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 03b43ccbfd65c17362003047e7fec8ecef3c3bb7 by \
Jaroslaw Staniek to branch calligra/2.9.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=348203">348203</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Consistency: use ILIKE/NOT ILIKE operator instead of \
LIKE for PostgreSQL</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">This fixes the issue "PostgreSQL uses \
case-sensitive search for LIKE SQL operator, Kexi's default is case-insensitive"</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The approach isn't generic enough for other \
expressions (the context of connection could be better) but it's already much better \
than ignoring differences between servers.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Queries work now for pgsql as for sqlite/mysql</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/kexidb/drivers/pqxx/pqxxdriver.cpp <span style="color: \
grey">(83f655c56a7d58c6f0aca87786261d0a6571345a)</span></li>
<li>kexi/plugins/queries/kexiquerydesignerguieditor.cpp <span style="color: \
grey">(2943df6bef7a08312ff19deeb2a146f1da0f450b)</span></li>
<li>kexi/widget/tableview/kexicomboboxpopup.cpp <span style="color: \
grey">(1a0e0eca61f881e638242197dc6cbeef8c69200a)</span></li>
<li>libs/db/connection.cpp <span style="color: \
grey">(af245efb17345f515cde3b4457f74e59a849077d)</span></li>
<li>libs/db/driver.cpp <span style="color: \
grey">(c1277a8993ced0ec7e4019fed990df8d4a0f5d5f)</span></li>
<li>libs/db/driver_p.h <span style="color: \
grey">(4cdfb5bf051ba3888ffe96974eee19e18a22269c)</span></li>
<li>libs/db/expression.h <span style="color: \
grey">(a7b0410a6172c7cc662213f540497855a97501ee)</span></li>
<li>libs/db/expression.cpp <span style="color: \
grey">(794732ea12830dfd09aac4cd0c16675e1ab6fedb)</span></li>
<li>libs/db/parser/parser_p.cpp <span style="color: \
grey">(5f11f4ea8ce947bf3e4e9dfd97e5f259776fc90b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123952/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1713615563890447538==--
[Attachment #3 (text/plain)]
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic