'Re: Review Request 123942: Keep pointer to related Connection object in query so it can be used to f'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Review Request 123942: Keep pointer to related Connection object in query so it can be used to f
From:       Jarosław_Staniek <staniek () kde ! org>
Date:       2015-05-30 19:32:22
Message-ID: 20150530193222.31615.46152 () mimi ! kde ! org
[Download RAW message or body]

--===============3090155755672249927==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123942/
-----------------------------------------------------------

(Updated May 30, 2015, 7:32 p.m.)

Status
------

This change has been marked as submitted.

Review request for Calligra, Andrius da Costa Ribas, Kamil Łysik, Friedrich W. H. \
Kossebau, Adam Pigg, Roman Shtemberko, Radosław Wicik, and Wojciech Kosowicz.

Changes
-------

Submitted with commit fd3942a3c5228acc224ac3afd4f0a4e83a56c16f by Jaroslaw Staniek to \
branch calligra/2.9.

Bugs: 330410
    http://bugs.kde.org/show_bug.cgi?id=330410

Repository: calligra

Description
-------

Keep pointer to related Connection object in query, so it can be used to find related \
tables

To do this, add a QuerySchema ctor and allow to call it internally by the parser.
We had to move QuerySchemaPrivate to separate files.

Diffs
-----

  libs/db/CMakeLists.txt 6de23f8bd2840c98623473781324b1ecd9e5fb56 
  libs/db/parser/sqlparser.h dde41990097f0f893b306e91a38220d12e942780 
  libs/db/parser/sqlparser.cpp 31713fbdbf4bb7e9c967842f6e5fd44f056bd770 
  libs/db/parser/sqlparser.y 12ab0180dcf161cd4760ca22871b48d0864b06be 
  libs/db/queryschema.h 3da6837467bf602854bc6d033eee2dd70775ac22 
  libs/db/queryschema.cpp bb71f979c1af96222e941120dadf5431deb46cc6 
  libs/db/queryschema_p.h PRE-CREATION 
  libs/db/queryschema_p.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/123942/diff/

Testing
-------

Queries work as expected, changes only relate to the conn pointer

Thanks,

Jarosław Staniek

--===============3090155755672249927==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123942/">https://git.reviewboard.kde.org/r/123942/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Calligra, Andrius da Costa Ribas, Kamil Łysik, Friedrich W. \
H. Kossebau, Adam Pigg, Roman Shtemberko, Radosław Wicik, and Wojciech \
Kosowicz.</div> <div>By Jarosław Staniek.</div>

<p style="color: grey;"><i>Updated May 30, 2015, 7:32 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit fd3942a3c5228acc224ac3afd4f0a4e83a56c16f by \
Jaroslaw Staniek to branch calligra/2.9.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=330410">330410</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Keep pointer to related Connection object in query, so \
it can be used to find related tables</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">To do this, add a \
QuerySchema ctor and allow to call it internally by the parser. We had to move \
QuerySchemaPrivate to separate files.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Queries work as expected, changes only relate to the conn pointer</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>libs/db/CMakeLists.txt <span style="color: \
grey">(6de23f8bd2840c98623473781324b1ecd9e5fb56)</span></li>

 <li>libs/db/parser/sqlparser.h <span style="color: \
grey">(dde41990097f0f893b306e91a38220d12e942780)</span></li>

 <li>libs/db/parser/sqlparser.cpp <span style="color: \
grey">(31713fbdbf4bb7e9c967842f6e5fd44f056bd770)</span></li>

 <li>libs/db/parser/sqlparser.y <span style="color: \
grey">(12ab0180dcf161cd4760ca22871b48d0864b06be)</span></li>

 <li>libs/db/queryschema.h <span style="color: \
grey">(3da6837467bf602854bc6d033eee2dd70775ac22)</span></li>

 <li>libs/db/queryschema.cpp <span style="color: \
grey">(bb71f979c1af96222e941120dadf5431deb46cc6)</span></li>

 <li>libs/db/queryschema_p.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>libs/db/queryschema_p.cpp <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123942/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3090155755672249927==--

[Attachment #3 (text/plain)]

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 