'Re: Review Request 123732: Replace obsolete QStyleOption::init()'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Review Request 123732: Replace obsolete QStyleOption::init()
From:       Jarosław_Staniek <staniek () kde ! org>
Date:       2015-05-20 21:43:01
Message-ID: 20150520214301.16315.54627 () mimi ! kde ! org
[Download RAW message or body]

--===============5481495355490531136==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

> On May 15, 2015, 12:11 a.m., Jarosław Staniek wrote:
> > Ship It!

Ping @Roman.

- Jarosław

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123732/#review80366
-----------------------------------------------------------

On May 12, 2015, 5:28 p.m., Roman Shtemberko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123732/
> -----------------------------------------------------------
> 
> (Updated May 12, 2015, 5:28 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> This function appears to be \
> [obsolete](http://doc.qt.io/qt-5/qstyleoption-obsolete.html). 
> 
> Diffs
> -----
> 
> kexi/kexiutils/KexiCloseButton.cpp 439acac 
> kexi/main/KexiMainWindow.cpp abd70f6 
> kexi/main/KexiMenuWidget.cpp ca6e268 
> kexi/widget/tableview/KexiTableScrollArea.cpp 536e0ea 
> libs/widgets/KoDockWidgetTitleBarButton.cpp 2892882 
> libs/widgets/KoResourceSelector.cpp c16e0a2 
> libs/widgets/KoSliderCombo.cpp 03506b8 
> 
> Diff: https://git.reviewboard.kde.org/r/123732/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Roman Shtemberko
> 
> 

--===============5481495355490531136==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123732/">https://git.reviewboard.kde.org/r/123732/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On May 15th, 2015, 12:11 a.m. CEST, <b>Jarosław \
Staniek</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ship It!</pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ping \
@Roman.</p></pre> <br />

<p>- Jarosław</p>

<br />
<p>On May 12th, 2015, 5:28 p.m. CEST, Roman Shtemberko wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Calligra and Jarosław Staniek.</div>
<div>By Roman Shtemberko.</div>

<p style="color: grey;"><i>Updated May 12, 2015, 5:28 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This function appears to be <a \
href="http://doc.qt.io/qt-5/qstyleoption-obsolete.html" style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">obsolete</a>.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kexi/kexiutils/KexiCloseButton.cpp <span style="color: \
grey">(439acac)</span></li>

 <li>kexi/main/KexiMainWindow.cpp <span style="color: grey">(abd70f6)</span></li>

 <li>kexi/main/KexiMenuWidget.cpp <span style="color: grey">(ca6e268)</span></li>

 <li>kexi/widget/tableview/KexiTableScrollArea.cpp <span style="color: \
grey">(536e0ea)</span></li>

 <li>libs/widgets/KoDockWidgetTitleBarButton.cpp <span style="color: \
grey">(2892882)</span></li>

 <li>libs/widgets/KoResourceSelector.cpp <span style="color: \
grey">(c16e0a2)</span></li>

 <li>libs/widgets/KoSliderCombo.cpp <span style="color: grey">(03506b8)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123732/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5481495355490531136==--

[Attachment #3 (text/plain)]

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 