[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request 123820: Create a slight delay for the color picker cursor in Krita
From: "Boudewijn Rempt" <boud () valdyas ! org>
Date: 2015-05-18 8:33:13
Message-ID: 20150518083313.16315.65828 () mimi ! kde ! org
[Download RAW message or body]
--===============5146264902303338821==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On May 18, 2015, 6:59 a.m., Boudewijn Rempt wrote:
> > krita/ui/tool/kis_tool_paint.cc, line 330
> > <https://git.reviewboard.kde.org/r/123820/diff/1/?file=369592#file369592line330>
> >
> > This doesn't build for me: it should be KisTool::NONE (gcc 4.8.3)
I'l push this and your other patch so more people can test them :-)
- Boudewijn
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123820/#review80558
-----------------------------------------------------------
On May 16, 2015, 5:46 p.m., Michael Abrahams wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123820/
> -----------------------------------------------------------
>
> (Updated May 16, 2015, 5:46 p.m.)
>
>
> Review request for Calligra.
>
>
> Repository: calligra
>
>
> Description
> -------
>
> This patch reduces the cursor flickering effect when ctrl-z is entered through a \
> keyboard macro in Krita (e.g. a Wacom tablet driver which has bound a side button \
> to ctrl-z)
> (Also fixes a typo)
>
>
> Diffs
> -----
>
> krita/ui/tool/kis_tool_paint.h 48c1f35
> krita/ui/tool/kis_tool_paint.cc 0c6b528
> krita/ui/input/wintab/kis_tablet_support_win.cpp 3ca5cea
>
> Diff: https://git.reviewboard.kde.org/r/123820/diff/
>
>
> Testing
> -------
>
> Works as intended
>
>
> Thanks,
>
> Michael Abrahams
>
>
--===============5146264902303338821==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123820/">https://git.reviewboard.kde.org/r/123820/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 18th, 2015, 6:59 a.m. UTC, <b>Boudewijn \
Rempt</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/123820/diff/1/?file=369592#file369592line330" \
style="color: black; font-weight: bold; text-decoration: \
underline;">krita/ui/tool/kis_tool_paint.cc</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KisToolPaint::pickColorWasOverridden()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">329</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">delayedAction</span> <span class="o">=</span> <span \
class="n">KisTool</span><span class="o">::</span><span \
class="n">AlternateAction</span><span class="o">::</span><span \
class="n">NONE</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
doesn't build for me: it should be KisTool::NONE (gcc 4.8.3)</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I'l push this and your other patch so more people can test them \
:-)</p></pre> <br />
<p>- Boudewijn</p>
<br />
<p>On May 16th, 2015, 5:46 p.m. UTC, Michael Abrahams wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Calligra.</div>
<div>By Michael Abrahams.</div>
<p style="color: grey;"><i>Updated May 16, 2015, 5:46 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch reduces the cursor flickering effect when \
ctrl-z is entered through a keyboard macro in Krita (e.g. a Wacom tablet driver which \
has bound a side button to ctrl-z)</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">(Also fixes a \
typo)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Works as intended</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/ui/tool/kis_tool_paint.h <span style="color: grey">(48c1f35)</span></li>
<li>krita/ui/tool/kis_tool_paint.cc <span style="color: grey">(0c6b528)</span></li>
<li>krita/ui/input/wintab/kis_tablet_support_win.cpp <span style="color: \
grey">(3ca5cea)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123820/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5146264902303338821==--
[Attachment #3 (text/plain)]
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic