[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request 123651: Kexi: Improvements for reports internal source combobox
From: Jarosław_Staniek <staniek () kde ! org>
Date: 2015-05-10 18:46:03
Message-ID: 20150510184603.17367.60978 () mimi ! kde ! org
[Download RAW message or body]
--===============4929223878601184973==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123651/#review80180
-----------------------------------------------------------
Ship it!
kexi/plugins/reports/kexireportpart.cpp (line 42)
<https://git.reviewboard.kde.org/r/123651/#comment55015>
-> sourceSelector
- Jarosław Staniek
On May 10, 2015, 5:33 p.m., Kamil Łysik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123651/
> -----------------------------------------------------------
>
> (Updated May 10, 2015, 5:33 p.m.)
>
>
> Review request for Calligra.
>
>
> Bugs: 347127
> http://bugs.kde.org/show_bug.cgi?id=347127
>
>
> Repository: calligra
>
>
> Description
> -------
>
> Kexi: Improvements for reports internal source combobox
>
>
> Diffs
> -----
>
> kexi/plugins/reports/CMakeLists.txt d563e17
> kexi/plugins/reports/InternalSourceSelector.h 384edc2
> kexi/plugins/reports/InternalSourceSelector.cpp 1729527
> kexi/plugins/reports/kexidbreportdata.h 5a5d367
> kexi/plugins/reports/kexidbreportdata.cpp d5cd54e
> kexi/plugins/reports/kexireportpart.cpp 88375c6
> kexi/plugins/reports/kexisourceselector.h 6dbf91f
> kexi/plugins/reports/kexisourceselector.cpp edf02eb
> kexi/widget/KexiDataSourceComboBox.cpp 112413b
>
> Diff: https://git.reviewboard.kde.org/r/123651/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kamil Łysik
>
>
--===============4929223878601184973==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123651/">https://git.reviewboard.kde.org/r/123651/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/123651/diff/2-3/?file=367879#file367879line42" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kexi/plugins/reports/kexireportpart.cpp</a> <span style="font-weight: \
normal;">
(Diff revisions 2 - 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">42</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">k<span \
class="hl">src</span></span> <span class="o">=</span> <span class="mi">0</span><span \
class="p">;</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">42</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">k<span \
class="hl">SourceSelector</span></span> <span class="o">=</span> <span \
class="mi">0</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">-> \
sourceSelector</p></pre> </div>
</div>
<br />
<p>- Jarosław Staniek</p>
<br />
<p>On May 10th, 2015, 5:33 p.m. CEST, Kamil Łysik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Calligra.</div>
<div>By Kamil Łysik.</div>
<p style="color: grey;"><i>Updated May 10, 2015, 5:33 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=347127">347127</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Kexi: Improvements for reports internal source \
combobox</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/plugins/reports/CMakeLists.txt <span style="color: \
grey">(d563e17)</span></li>
<li>kexi/plugins/reports/InternalSourceSelector.h <span style="color: \
grey">(384edc2)</span></li>
<li>kexi/plugins/reports/InternalSourceSelector.cpp <span style="color: \
grey">(1729527)</span></li>
<li>kexi/plugins/reports/kexidbreportdata.h <span style="color: \
grey">(5a5d367)</span></li>
<li>kexi/plugins/reports/kexidbreportdata.cpp <span style="color: \
grey">(d5cd54e)</span></li>
<li>kexi/plugins/reports/kexireportpart.cpp <span style="color: \
grey">(88375c6)</span></li>
<li>kexi/plugins/reports/kexisourceselector.h <span style="color: \
grey">(6dbf91f)</span></li>
<li>kexi/plugins/reports/kexisourceselector.cpp <span style="color: \
grey">(edf02eb)</span></li>
<li>kexi/widget/KexiDataSourceComboBox.cpp <span style="color: \
grey">(112413b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123651/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4929223878601184973==--
[Attachment #3 (text/plain)]
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic