[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request 123667: Added user script API docs for check box item
From: Jarosław_Staniek <staniek () kde ! org>
Date: 2015-05-07 17:25:06
Message-ID: 20150507172506.16998.93380 () mimi ! kde ! org
[Download RAW message or body]
--===============9074189848710689012==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123667/#review80053
-----------------------------------------------------------
Ship it!
Ship It!
- Jarosław Staniek
On May 6, 2015, 11:16 p.m., Adam Pigg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123667/
> -----------------------------------------------------------
>
> (Updated May 6, 2015, 11:16 p.m.)
>
>
> Review request for Calligra and Jarosław Staniek.
>
>
> Repository: calligra
>
>
> Description
> -------
>
> Added docs and const for image item
>
>
> Added text item docs
>
>
> fixed indent
>
>
> Line item api docs
>
>
> Diffs
> -----
>
> libs/koreport/items/check/KoReportScriptCheck.h \
> e7f0f4f7db01191c99dee8808266b3b276a5dd31 \
> libs/koreport/items/check/KoReportScriptCheck.cpp \
> 0e17ceae1fc66ecdeba1618a85a076e4602c8967 libs/koreport/items/image/krscriptimage.h \
> 25ae0f4ad54aea6a8dc1454d7e42beabbfb6a908 \
> libs/koreport/items/image/krscriptimage.cpp \
> 53176417ade0554557ac8fc973ad3f291af0d995 libs/koreport/items/text/krscripttext.h \
> bc0b7633f3220319580bdec18f4d8860be01f8a7 libs/koreport/items/text/krscripttext.cpp \
> 671079502eadda2eb381d23351e1d027d1c245fd \
> libs/koreport/renderer/scripting/krscriptline.h \
> 8bbbacea655a14ace94448dfea655a027506a808
> Diff: https://git.reviewboard.kde.org/r/123667/diff/
>
>
> Testing
> -------
>
> none, no code changes
>
> checked docs are generated
>
>
> Thanks,
>
> Adam Pigg
>
>
--===============9074189848710689012==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123667/">https://git.reviewboard.kde.org/r/123667/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Jarosław Staniek</p>
<br />
<p>On May 6th, 2015, 11:16 p.m. CEST, Adam Pigg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Calligra and Jarosław Staniek.</div>
<div>By Adam Pigg.</div>
<p style="color: grey;"><i>Updated May 6, 2015, 11:16 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Added docs and const for image item
Added text item docs
fixed indent
Line item api docs</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">none, no code changes</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">checked docs are generated</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/koreport/items/check/KoReportScriptCheck.h <span style="color: \
grey">(e7f0f4f7db01191c99dee8808266b3b276a5dd31)</span></li>
<li>libs/koreport/items/check/KoReportScriptCheck.cpp <span style="color: \
grey">(0e17ceae1fc66ecdeba1618a85a076e4602c8967)</span></li>
<li>libs/koreport/items/image/krscriptimage.h <span style="color: \
grey">(25ae0f4ad54aea6a8dc1454d7e42beabbfb6a908)</span></li>
<li>libs/koreport/items/image/krscriptimage.cpp <span style="color: \
grey">(53176417ade0554557ac8fc973ad3f291af0d995)</span></li>
<li>libs/koreport/items/text/krscripttext.h <span style="color: \
grey">(bc0b7633f3220319580bdec18f4d8860be01f8a7)</span></li>
<li>libs/koreport/items/text/krscripttext.cpp <span style="color: \
grey">(671079502eadda2eb381d23351e1d027d1c245fd)</span></li>
<li>libs/koreport/renderer/scripting/krscriptline.h <span style="color: \
grey">(8bbbacea655a14ace94448dfea655a027506a808)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123667/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============9074189848710689012==--
[Attachment #3 (text/plain)]
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic