'Re: Review Request 123511: Move KoXmlVector into separate file and add unit tests'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Review Request 123511: Move KoXmlVector into separate file and add unit tests
From:       "Boudewijn Rempt" <boud () valdyas ! org>
Date:       2015-05-01 10:51:24
Message-ID: 20150501105124.32057.37623 () mimi ! kde ! org
[Download RAW message or body]

--===============1457678166288971259==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123511/#review79758
-----------------------------------------------------------

Ship it!

Ship It!

- Boudewijn Rempt

On April 26, 2015, 9:12 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123511/
> -----------------------------------------------------------
> 
> (Updated April 26, 2015, 9:12 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> While investigating the KoLZF compress/decompress methods and what data actually is \
> processed there, I also had to grasp what KoXmlVector is doing. To help myself I \
> wrote some unit tests for it (for which I needed to move the class into an own \
> file). Given they exist now, proposing to add those unit tests to the Calligra \
> repo, including a little bit more documentation, so they might help protecting \
> against any future regressions (e.g. during the Qt5/KF5 port) :) 
> 
> Diffs
> -----
> 
> libs/odf/KoXmlReader.cpp 75b1114 
> libs/odf/KoXmlVector.h PRE-CREATION 
> libs/odf/tests/CMakeLists.txt 689bfe4 
> libs/odf/tests/TestKoXmlVector.h PRE-CREATION 
> libs/odf/tests/TestKoXmlVector.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123511/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
> 

--===============1457678166288971259==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123511/">https://git.reviewboard.kde.org/r/123511/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Boudewijn Rempt</p>

<br />
<p>On April 26th, 2015, 9:12 p.m. UTC, Friedrich W. H. Kossebau wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>

<p style="color: grey;"><i>Updated April 26, 2015, 9:12 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">While investigating the KoLZF compress/decompress \
methods and what data actually is processed there, I also had to grasp what \
KoXmlVector is doing. To help myself I wrote some unit tests for it (for which I \
needed to move the class into an own file). Given they exist now, proposing to add \
those unit tests to the Calligra repo, including a little bit more documentation, so \
they might help protecting against any future regressions (e.g. during the Qt5/KF5 \
port) :)</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>libs/odf/KoXmlReader.cpp <span style="color: grey">(75b1114)</span></li>

 <li>libs/odf/KoXmlVector.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>libs/odf/tests/CMakeLists.txt <span style="color: grey">(689bfe4)</span></li>

 <li>libs/odf/tests/TestKoXmlVector.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>libs/odf/tests/TestKoXmlVector.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123511/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1457678166288971259==--

[Attachment #3 (text/plain)]

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 