[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request 123486: Fix a bug when KoResourceItemChooser's current resource was resent on res
From: "Boudewijn Rempt" <boud () valdyas ! org>
Date: 2015-04-24 14:00:39
Message-ID: 20150424140039.5446.63195 () mimi ! kde ! org
[Download RAW message or body]
--===============4618597951935248890==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123486/#review79445
-----------------------------------------------------------
Ship it!
I'd prefer a commit per fix, but ship-it.
- Boudewijn Rempt
On April 24, 2015, 9:49 a.m., Dmitry Kazakov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123486/
> -----------------------------------------------------------
>
> (Updated April 24, 2015, 9:49 a.m.)
>
>
> Review request for Calligra.
>
>
> Repository: calligra
>
>
> Description
> -------
>
> This patch fixes numerous bugs in KoResourceItemChooser
>
> 1) Resizing the widged and then hide/show used to reset currently selected \
> resource. That caused user's paintop presets and styles being invalidated by simply \
> showing the widget on screen. Now this problem has gone, because the \
> madoel()->reset() call is done in two stages with first saving the current \
> selection and then restoring it when the reset is finished.
> 2) Now the number of columns is calculated dynamically when the widget is being \
> resized. Before the patch there was a weird behaviour: when resizing the widget the \
> tiles were **scaled only**, and after the next hide/show the **number of columns** \
> would be recalculated. Now both steps are executed simultaneously.
> 3) The size of the preview splitter in KisPatternChooser is now fixed, so the user \
> would see at least something :)
>
> Diffs
> -----
>
> libs/widgets/KoResourceModel.cpp 3b2f5e3
> libs/widgets/KoResourceModel.h 06a7135
> libs/widgets/KoResourceItemView.cpp e5d9e5a
> libs/widgets/KoResourceItemView.h 9b712ed
> libs/widgets/KoResourceItemChooser.cpp 6e5c349
> libs/widgets/KoResourceItemChooser.h e41bd26
> krita/ui/widgets/kis_pattern_chooser.cc 9568d3b
>
> Diff: https://git.reviewboard.kde.org/r/123486/diff/
>
>
> Testing
> -------
>
> Tested in Krita only
>
>
> Thanks,
>
> Dmitry Kazakov
>
>
--===============4618597951935248890==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123486/">https://git.reviewboard.kde.org/r/123486/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'd \
prefer a commit per fix, but ship-it.</p></pre> <br />
<p>- Boudewijn Rempt</p>
<br />
<p>On April 24th, 2015, 9:49 a.m. UTC, Dmitry Kazakov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Calligra.</div>
<div>By Dmitry Kazakov.</div>
<p style="color: grey;"><i>Updated April 24, 2015, 9:49 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch fixes numerous bugs in \
KoResourceItemChooser</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">1) Resizing the widged and then \
hide/show used to reset currently selected resource. That caused user's paintop \
presets and styles being invalidated by simply showing the widget on screen. Now this \
problem has gone, because the madoel()->reset() call is done in two stages with \
first saving the current selection and then restoring it when the reset is \
finished.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">2) Now the number of columns is calculated dynamically \
when the widget is being resized. Before the patch there was a weird behaviour: when \
resizing the widget the tiles were <strong style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">scaled only</strong>, \
and after the next hide/show the <strong style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">number of \
columns</strong> would be recalculated. Now both steps are executed \
simultaneously.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">3) The size of the preview splitter in \
KisPatternChooser is now fixed, so the user would see at least something :)</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested in Krita only</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/widgets/KoResourceModel.cpp <span style="color: grey">(3b2f5e3)</span></li>
<li>libs/widgets/KoResourceModel.h <span style="color: grey">(06a7135)</span></li>
<li>libs/widgets/KoResourceItemView.cpp <span style="color: \
grey">(e5d9e5a)</span></li>
<li>libs/widgets/KoResourceItemView.h <span style="color: \
grey">(9b712ed)</span></li>
<li>libs/widgets/KoResourceItemChooser.cpp <span style="color: \
grey">(6e5c349)</span></li>
<li>libs/widgets/KoResourceItemChooser.h <span style="color: \
grey">(e41bd26)</span></li>
<li>krita/ui/widgets/kis_pattern_chooser.cc <span style="color: \
grey">(9568d3b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123486/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4618597951935248890==--
[Attachment #3 (text/plain)]
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic