'Re: Review Request 123460: No need for Karbon to register a path for resource type "kis_brushes", ri'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Review Request 123460: No need for Karbon to register a path for resource type "kis_brushes", ri
From:       "Boudewijn Rempt" <boud () valdyas ! org>
Date:       2015-04-21 21:36:51
Message-ID: 20150421213651.5446.31356 () mimi ! kde ! org
[Download RAW message or body]

--===============2254414155011767143==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123460/#review79309
-----------------------------------------------------------

Ship it!

I suspect that this was originally meant when Jan wanted karbon to stroke paths with \
gimp brushes. Maybe first remove in 2.9?

- Boudewijn Rempt

On April 21, 2015, 9:29 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123460/
> -----------------------------------------------------------
> 
> (Updated April 21, 2015, 9:29 p.m.)
> 
> 
> Review request for Calligra, Yue Liu and Boudewijn Rempt.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Karbon has `s_instance->dirs()->addResourceType("kis_brushes", "data", \
> "krita/brushes/");`. Seems like that registration is there forever. But in current \
> code I cannot see how Karbon could make use of brushes. And at least all code using \
> such resource types is in krita/libbrush/kis_brush_server.cpp, so should be also \
> self-contained. 
> Might have missed something, so asking the experts if this is really a bogus \
> registration. 
> 
> Diffs
> -----
> 
> karbon/ui/KarbonFactory.cpp 464bb0a 
> 
> Diff: https://git.reviewboard.kde.org/r/123460/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
> 

--===============2254414155011767143==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123460/">https://git.reviewboard.kde.org/r/123460/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
suspect that this was originally meant when Jan wanted karbon to stroke paths with \
gimp brushes. Maybe first remove in 2.9?</p></pre>  <br />

<p>- Boudewijn Rempt</p>

<br />
<p>On April 21st, 2015, 9:29 p.m. UTC, Friedrich W. H. Kossebau wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Calligra, Yue Liu and Boudewijn Rempt.</div>
<div>By Friedrich W. H. Kossebau.</div>

<p style="color: grey;"><i>Updated April 21, 2015, 9:29 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Karbon has <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">s_instance-&gt;dirs()-&gt;addResourceType("kis_brushes", "data", \
"krita/brushes/");</code>. Seems like that registration is there forever. But in \
current code I cannot see how Karbon could make use of brushes. And at least all code \
using such resource types is in krita/libbrush/kis_brush_server.cpp, so should be \
also self-contained.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Might have missed something, so asking \
the experts if this is really a bogus registration.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>karbon/ui/KarbonFactory.cpp <span style="color: grey">(464bb0a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123460/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============2254414155011767143==--

[Attachment #3 (text/plain)]

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 