From calligra-devel  Fri Jul 11 19:58:31 2014
From: "Adam Pigg" <adam () piggz ! co ! uk>
Date: Fri, 11 Jul 2014 19:58:31 +0000
To: calligra-devel
Subject: Re: Review Request 119169: Cleanup for report element tag names, use namespaces consistently
Message-Id: <20140711195831.19519.37933 () probe ! kde ! org>
X-MARC-Message: https://marc.info/?l=calligra-devel&m=140510873006143
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============4299561077614176355=="

--===============4299561077614176355==
Content-Type: multipart/alternative;
 boundary="===============8963995719824799264=="

--===============8963995719824799264==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119169/#review62152
-----------------------------------------------------------


Have you tested loading existing reports with all elements?

- Adam Pigg


On July 7, 2014, 11:43 p.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119169/
> -----------------------------------------------------------
> 
> (Updated July 7, 2014, 11:43 p.m.)
> 
> 
> Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, Radosław Wicik, and Wojciech Kosowicz.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Cleanup for report element tag names, use namespaces consistently
> 
> 
> Diffs
> -----
> 
>   plugins/reporting/maps/KoReportItemMaps.cpp 1f6e7fc865f37a197cba467e433c100d0facaf05 
>   plugins/reporting/maps/KoReportMapsPlugin.cpp 90e42aee6cf3c2629bd74250d38002d7b8ca958c 
>   plugins/reporting/web/KoReportDesignerItemWeb.cpp 63e1cc9a706de0cef5e8555e5e731c70181455ae 
>   plugins/reporting/web/KoReportWebPlugin.cpp d9b4f5cf63f9eb3811bd63c6ff016b369fc2c494 
>   plugins/reporting/maps/KoReportDesignerItemMaps.cpp f624db3192f7801f26944faf997b147569778ef0 
>   plugins/reporting/chart/KoReportChartPlugin.cpp 519c7865bd785c93a602bc63c78c1f4d72ed9ec6 
>   plugins/reporting/chart/KoReportDesignerItemChart.cpp 65ce99b154e70e4a56548568b8ecc283eb306b26 
>   plugins/reporting/barcode/KoReportBarcodePlugin.cpp a2314a80455590f5c5c194731715ae4444946a50 
>   plugins/reporting/barcode/KoReportDesignerItemBarcode.cpp b4fb621d5b2bd0dc59afa33f62dc01dd52e9b491 
>   libs/koreport/wrtembed/KoReportDesignerItemLine.cpp 1b0474d1b849d0aad1c3356f1d92f774ac9c98d5 
>   libs/koreport/wrtembed/reportsection.cpp 9992f422939ff145e9a429e126a896861ee6ec7d 
>   libs/koreport/renderer/scripting/krscriptsection.cpp 28b05202f996d40d4ebbca2e583e8fce251f9d49 
>   libs/koreport/common/krsectiondata.cpp ae3c73c7edca6d16a97c71727cdbd8c39bcd761c 
>   libs/koreport/items/check/KoReportCheckPlugin.cpp 906488ca231bcc4d011eecf62f59eb1f075da427 
>   libs/koreport/items/check/KoReportDesignerItemCheck.cpp 5bebc6c4e10f2243919a0b2668ea3a8ff02ce954 
>   libs/koreport/items/check/KoReportItemCheck.cpp 188d5ab232a31347ca24f91c81411683eb6256c9 
>   libs/koreport/items/field/KoReportDesignerItemField.cpp 0dc9325a1c04dda83bdc7c2a3e4eae5eb500c52f 
>   libs/koreport/items/field/KoReportFieldPlugin.cpp 5ed590b68e0bdca79cac4fbdff7bd02d3e2264fb 
>   libs/koreport/items/field/KoReportItemField.cpp 9b12fe184bf56410ae8af33280eb64e735f36e3d 
>   libs/koreport/items/image/KoReportDesignerItemImage.cpp 87e46a1ca3ad6dc0a025eeac90dac12e12029691 
>   libs/koreport/items/image/KoReportImagePlugin.cpp 6de963f6df5f41a02eef6d0b7aa785e0d6987871 
>   libs/koreport/items/image/KoReportItemImage.cpp e1b2965686a607e0739b70f10b11ea63068d4223 
>   libs/koreport/items/label/KoReportDesignerItemLabel.cpp 8974a807b122649a6c6daf61f34c678cb5ec9961 
>   libs/koreport/items/label/KoReportItemLabel.cpp 78be96aad00ca8375d0a9c7e1aa7c1dd8e162bee 
>   libs/koreport/items/label/KoReportLabelPlugin.cpp 0eb154a072efd0780488e46c07379e66fa32ed00 
>   libs/koreport/items/text/KoReportDesignerItemText.cpp 51e12d3020104fec4cb8cc473d5499e085dfbf2c 
>   libs/koreport/items/text/KoReportItemText.cpp 2f4703a0c8847a29c41ee4c21b2c58744334b1a6 
>   libs/koreport/items/text/KoReportTextPlugin.cpp db835f8263e18842fe49ca144fa83b08d1deafc5 
>   libs/koreport/renderer/KoReportPreRenderer.cpp a7913fff95bdcef47ddb58c969fbdabb2a9774bc 
>   libs/koreport/renderer/scripting/krscriptreport.cpp 7834c7e744ba9e3723fcbb3d3eaf9d9254a56572 
> 
> Diff: https://git.reviewboard.kde.org/r/119169/diff/
> 
> 
> Testing
> -------
> 
> tested by working with report elements
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>


--===============8963995719824799264==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119169/">https://git.reviewboard.kde.org/r/119169/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Have you tested loading existing reports with all elements?</p></pre>
 <br />









<p>- Adam Pigg</p>


<br />
<p>On July 7th, 2014, 11:43 p.m. UTC, Jarosław Staniek wrote:</p>









<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
 <tr>
  <td>

<div>Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, Radosław Wicik, and Wojciech Kosowicz.</div>
<div>By Jarosław Staniek.</div>


<p style="color: grey;"><i>Updated July 7, 2014, 11:43 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Cleanup for report element tag names, use namespaces consistently</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">tested by working with report elements</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plugins/reporting/maps/KoReportItemMaps.cpp <span style="color: grey">(1f6e7fc865f37a197cba467e433c100d0facaf05)</span></li>

 <li>plugins/reporting/maps/KoReportMapsPlugin.cpp <span style="color: grey">(90e42aee6cf3c2629bd74250d38002d7b8ca958c)</span></li>

 <li>plugins/reporting/web/KoReportDesignerItemWeb.cpp <span style="color: grey">(63e1cc9a706de0cef5e8555e5e731c70181455ae)</span></li>

 <li>plugins/reporting/web/KoReportWebPlugin.cpp <span style="color: grey">(d9b4f5cf63f9eb3811bd63c6ff016b369fc2c494)</span></li>

 <li>plugins/reporting/maps/KoReportDesignerItemMaps.cpp <span style="color: grey">(f624db3192f7801f26944faf997b147569778ef0)</span></li>

 <li>plugins/reporting/chart/KoReportChartPlugin.cpp <span style="color: grey">(519c7865bd785c93a602bc63c78c1f4d72ed9ec6)</span></li>

 <li>plugins/reporting/chart/KoReportDesignerItemChart.cpp <span style="color: grey">(65ce99b154e70e4a56548568b8ecc283eb306b26)</span></li>

 <li>plugins/reporting/barcode/KoReportBarcodePlugin.cpp <span style="color: grey">(a2314a80455590f5c5c194731715ae4444946a50)</span></li>

 <li>plugins/reporting/barcode/KoReportDesignerItemBarcode.cpp <span style="color: grey">(b4fb621d5b2bd0dc59afa33f62dc01dd52e9b491)</span></li>

 <li>libs/koreport/wrtembed/KoReportDesignerItemLine.cpp <span style="color: grey">(1b0474d1b849d0aad1c3356f1d92f774ac9c98d5)</span></li>

 <li>libs/koreport/wrtembed/reportsection.cpp <span style="color: grey">(9992f422939ff145e9a429e126a896861ee6ec7d)</span></li>

 <li>libs/koreport/renderer/scripting/krscriptsection.cpp <span style="color: grey">(28b05202f996d40d4ebbca2e583e8fce251f9d49)</span></li>

 <li>libs/koreport/common/krsectiondata.cpp <span style="color: grey">(ae3c73c7edca6d16a97c71727cdbd8c39bcd761c)</span></li>

 <li>libs/koreport/items/check/KoReportCheckPlugin.cpp <span style="color: grey">(906488ca231bcc4d011eecf62f59eb1f075da427)</span></li>

 <li>libs/koreport/items/check/KoReportDesignerItemCheck.cpp <span style="color: grey">(5bebc6c4e10f2243919a0b2668ea3a8ff02ce954)</span></li>

 <li>libs/koreport/items/check/KoReportItemCheck.cpp <span style="color: grey">(188d5ab232a31347ca24f91c81411683eb6256c9)</span></li>

 <li>libs/koreport/items/field/KoReportDesignerItemField.cpp <span style="color: grey">(0dc9325a1c04dda83bdc7c2a3e4eae5eb500c52f)</span></li>

 <li>libs/koreport/items/field/KoReportFieldPlugin.cpp <span style="color: grey">(5ed590b68e0bdca79cac4fbdff7bd02d3e2264fb)</span></li>

 <li>libs/koreport/items/field/KoReportItemField.cpp <span style="color: grey">(9b12fe184bf56410ae8af33280eb64e735f36e3d)</span></li>

 <li>libs/koreport/items/image/KoReportDesignerItemImage.cpp <span style="color: grey">(87e46a1ca3ad6dc0a025eeac90dac12e12029691)</span></li>

 <li>libs/koreport/items/image/KoReportImagePlugin.cpp <span style="color: grey">(6de963f6df5f41a02eef6d0b7aa785e0d6987871)</span></li>

 <li>libs/koreport/items/image/KoReportItemImage.cpp <span style="color: grey">(e1b2965686a607e0739b70f10b11ea63068d4223)</span></li>

 <li>libs/koreport/items/label/KoReportDesignerItemLabel.cpp <span style="color: grey">(8974a807b122649a6c6daf61f34c678cb5ec9961)</span></li>

 <li>libs/koreport/items/label/KoReportItemLabel.cpp <span style="color: grey">(78be96aad00ca8375d0a9c7e1aa7c1dd8e162bee)</span></li>

 <li>libs/koreport/items/label/KoReportLabelPlugin.cpp <span style="color: grey">(0eb154a072efd0780488e46c07379e66fa32ed00)</span></li>

 <li>libs/koreport/items/text/KoReportDesignerItemText.cpp <span style="color: grey">(51e12d3020104fec4cb8cc473d5499e085dfbf2c)</span></li>

 <li>libs/koreport/items/text/KoReportItemText.cpp <span style="color: grey">(2f4703a0c8847a29c41ee4c21b2c58744334b1a6)</span></li>

 <li>libs/koreport/items/text/KoReportTextPlugin.cpp <span style="color: grey">(db835f8263e18842fe49ca144fa83b08d1deafc5)</span></li>

 <li>libs/koreport/renderer/KoReportPreRenderer.cpp <span style="color: grey">(a7913fff95bdcef47ddb58c969fbdabb2a9774bc)</span></li>

 <li>libs/koreport/renderer/scripting/krscriptreport.cpp <span style="color: grey">(7834c7e744ba9e3723fcbb3d3eaf9d9254a56572)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119169/diff/" style="margin-left: 3em;">View Diff</a></p>






  </td>
 </tr>
</table>








  </div>
 </body>
</html>


--===============8963995719824799264==--

--===============4299561077614176355==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

--===============4299561077614176355==--