'Review Request 112883: Workaround for flickering in OpenGL 2 canvas on AMD graphic cards'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Review Request 112883: Workaround for flickering in OpenGL 2 canvas on AMD graphic cards
From:       "Sven Langkamp" <sven.langkamp () gmail ! com>
Date:       2013-09-22 11:01:56
Message-ID: 20130922110156.28544.42008 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112883/
-----------------------------------------------------------

Review request for Calligra and Boudewijn Rempt.

Description
-------

On AMD graphic cards the Krita OpengGL 2 branch shows some flickering. The problem \
happens when only a part of the widget is updated e.g. when switching between menu.

The patch solves that by dropping paint events that update that have an update rect \
smaller than the size of the widget. In that case a new update with the full size of \
the widget is trigger.

It's somewhat of an ugly hack, but it's the best solution that I could find. Better \
suggestions appreciated.

This addresses bug 322808.
    http://bugs.kde.org/show_bug.cgi?id=322808

Diffs
-----

  krita/ui/opengl/kis_opengl_canvas2.h 5d701d6 
  krita/ui/opengl/kis_opengl_canvas2.cpp 2ddd503 

Diff: http://git.reviewboard.kde.org/r/112883/diff/

Testing
-------

Tested on my ATI card. Flickering is gone.

Thanks,

Sven Langkamp

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112883/">http://git.reviewboard.kde.org/r/112883/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Calligra and Boudewijn Rempt.</div>
<div>By Sven Langkamp.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">On AMD graphic cards the Krita OpengGL 2 branch shows some flickering. \
The problem happens when only a part of the widget is updated e.g. when switching \
between menu.

The patch solves that by dropping paint events that update that have an update rect \
smaller than the size of the widget. In that case a new update with the full size of \
the widget is trigger.

It&#39;s somewhat of an ugly hack, but it&#39;s the best solution that I could find. \
Better suggestions appreciated.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested on my ATI card. Flickering is gone.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=322808">322808</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>krita/ui/opengl/kis_opengl_canvas2.h <span style="color: \
grey">(5d701d6)</span></li>

 <li>krita/ui/opengl/kis_opengl_canvas2.cpp <span style="color: \
grey">(2ddd503)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112883/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 