'Re: Review Request 112827: Move the View Mode button from KisPaintOpPresetsChooserPopup to KoResourc'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Review Request 112827: Move the View Mode button from KisPaintOpPresetsChooserPopup to KoResourc
From:       "Commit Hook" <null () kde ! org>
Date:       2013-09-19 16:38:08
Message-ID: 20130919163808.19024.28803 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112827/
-----------------------------------------------------------

(Updated Sept. 19, 2013, 4:38 p.m.)

Status
------

This change has been marked as submitted.

Review request for Calligra and Boudewijn Rempt.

Description
-------

Krita has a button to choose the view mode for the preset selectors. In recent times, \
tagging support was added to KoResourceItemChooser. Now, the layour of the preset \
selector in Krita is messed up because the view mode button is put above the resource \
chooser, costing valueable vertical space. This patch removes that button and adds it \
to KoResourceItemChooser, by default hidden. It does not actually do anything but \
provide an attachment point for the menu that is added by Krita, since the actual \
view mode change is dependant on the delegate used.

Diffs
-----

  krita/ui/forms/wdgpaintoppresets.ui bb95281 
  krita/ui/widgets/kis_paintop_presets_chooser_popup.cpp 078c572 
  libs/widgets/KoResourceItemChooser.h 91ed650 
  libs/widgets/KoResourceItemChooser.cpp 62be3c6 

Diff: http://git.reviewboard.kde.org/r/112827/diff/

Testing
-------

Build and run, everything works.

File Attachments
----------------

After the change
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/19/viewmodebutton_after.png
 Before the change
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/19/viewmodebutton_before.png

Thanks,

Arjen Hiemstra

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112827/">http://git.reviewboard.kde.org/r/112827/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Calligra and Boudewijn Rempt.</div>
<div>By Arjen Hiemstra.</div>

<p style="color: grey;"><i>Updated Sept. 19, 2013, 4:38 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Krita has a button to choose the view mode for the preset selectors. In \
recent times, tagging support was added to KoResourceItemChooser. Now, the layour of \
the preset selector in Krita is messed up because the view mode button is put above \
the resource chooser, costing valueable vertical space. This patch removes that \
button and adds it to KoResourceItemChooser, by default hidden. It does not actually \
do anything but provide an attachment point for the menu that is added by Krita, \
since the actual view mode change is dependant on the delegate used.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Build and run, everything works.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>krita/ui/forms/wdgpaintoppresets.ui <span style="color: \
grey">(bb95281)</span></li>

 <li>krita/ui/widgets/kis_paintop_presets_chooser_popup.cpp <span style="color: \
grey">(078c572)</span></li>

 <li>libs/widgets/KoResourceItemChooser.h <span style="color: \
grey">(91ed650)</span></li>

 <li>libs/widgets/KoResourceItemChooser.cpp <span style="color: \
grey">(62be3c6)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112827/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

<ul>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/19/viewmodebutton_after.png">After \
the change</a></li>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/19/viewmodebutton_before.png">Before \
the change</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 