[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: deleting children of KoShapeContainer
From:       jaham () gmx ! net
Date:       2011-04-20 16:07:52
Message-ID: 201104201807.52967.jaham () gmx ! net
[Download RAW message or body]

On Wednesday 20 April 2011 14:27:53 Boudewijn Rempt wrote:
> On Wednesday 20 April 2011 Apr, C. Boemann wrote:
> > Hi
> > 
> > I believe it's important for the KoShapeContainer to delete it's
> > children.
> 
> Well, we should have a clear idea on how to handle memory management for
> shapes. Until now, it's been clear that the container/group isn't
> responsible for deleting shapes, and we never had a real parent-child
> relationship for shapes, like QGraphicsView has for QGraphicsItems.
> 
> So I think that the application should remember which shapes it has created
> and delete them. Since shape containers are shapes as well, those can be
> deleted as well.
> 
> I don't think there should be transitive deletion of shapes like you get
> with you delete a QObject or a QGraphicsItem.
> 
> > I have a crash related to not all shapes being deleted.
> 
> I think that crash should be fixed in Stage, not in Flake.
> 
> > However I also think that for some grouping ungrouping kind of things it
> > is changing behaviour

What's more to say other than I completely agree!

Ciao Jan
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]